Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clone node to remove location even when it has been modified if needed #58706

Merged
merged 6 commits into from
May 31, 2024
Merged

Clone node to remove location even when it has been modified if needed #58706

merged 6 commits into from
May 31, 2024

Conversation

weswigham
Copy link
Member

Because when a node is updated because its' children changed, location data is, by default, copied by the node update functions. In addition, I also handle deleting location data from node arrays from other files as well, as I noticed that while debugging.
 
Additionally, one of the comment range copies in the test was coming from an unchecked setCommentRange outside the node copying code, so that now has builtin checks now, too.

Fixes #58698

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 29, 2024
@weswigham weswigham marked this pull request as ready for review May 30, 2024 23:26
@jakebailey
Copy link
Member

Wow, this is a big baseline change, but maybe it's just going to have to happen given #58698 is a bad bug?

@jakebailey
Copy link
Member

Would run perf on this but I think the merge conflict will make the bot mad.

@jakebailey
Copy link
Member

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 31, 2024 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
perf test this ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 30 30 ~ ~ ~ p=1.000 n=6
Symbols 62,153 62,153 ~ ~ ~ p=1.000 n=6
Types 50,242 50,242 ~ ~ ~ p=1.000 n=6
Memory used 194,716k (± 0.93%) 192,937k (± 0.74%) ~ 192,325k 195,870k p=0.066 n=6
Parse Time 1.96s (± 0.70%) 1.95s (± 0.65%) ~ 1.93s 1.97s p=0.103 n=6
Bind Time 1.07s (± 1.42%) 1.06s (± 0.71%) ~ 1.05s 1.07s p=0.867 n=6
Check Time 14.02s (± 0.61%) 14.06s (± 0.73%) ~ 13.86s 14.15s p=0.422 n=6
Emit Time 3.99s (± 1.09%) 4.05s (± 0.75%) +0.06s (+ 1.55%) 4.02s 4.10s p=0.024 n=6
Total Time 21.04s (± 0.37%) 21.12s (± 0.34%) +0.08s (+ 0.36%) 20.98s 21.20s p=0.045 n=6
angular-1 - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 944,109 944,109 ~ ~ ~ p=1.000 n=6
Types 407,049 407,049 ~ ~ ~ p=1.000 n=6
Memory used 1,222,140k (± 0.00%) 1,222,157k (± 0.00%) ~ 1,222,101k 1,222,213k p=0.298 n=6
Parse Time 8.09s (± 0.60%) 8.12s (± 0.68%) ~ 8.03s 8.18s p=0.470 n=6
Bind Time 2.23s (± 0.84%) 2.25s (± 0.97%) ~ 2.22s 2.28s p=0.256 n=6
Check Time 36.52s (± 0.11%) 36.47s (± 0.36%) ~ 36.28s 36.64s p=0.575 n=6
Emit Time 18.10s (± 0.59%) 18.12s (± 0.41%) ~ 18.03s 18.23s p=0.630 n=6
Total Time 64.95s (± 0.25%) 64.95s (± 0.17%) ~ 64.81s 65.12s p=0.873 n=6
mui-docs - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 2,051,460 2,051,460 ~ ~ ~ p=1.000 n=6
Types 899,446 899,446 ~ ~ ~ p=1.000 n=6
Memory used 2,065,714k (± 0.00%) 2,065,597k (± 0.00%) -117k (- 0.01%) 2,065,464k 2,065,693k p=0.020 n=6
Parse Time 9.94s (± 0.29%) 9.98s (± 0.21%) ~ 9.94s 10.00s p=0.052 n=6
Bind Time 3.36s (± 1.01%) 3.38s (± 0.76%) ~ 3.34s 3.42s p=0.288 n=6
Check Time 99.88s (± 1.21%) 99.49s (± 1.89%) ~ 96.89s 100.96s p=0.936 n=6
Emit Time 0.20s (± 2.67%) 0.20s (± 2.02%) ~ 0.20s 0.21s p=0.282 n=6
Total Time 113.39s (± 1.04%) 113.05s (± 1.66%) ~ 110.43s 114.48s p=0.936 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,229,666 1,229,706 +40 (+ 0.00%) ~ ~ p=0.001 n=6
Types 260,899 260,911 +12 (+ 0.00%) ~ ~ p=0.001 n=6
Memory used 2,376,011k (± 2.59%) 2,376,495k (± 2.62%) ~ 2,349,580k 2,503,599k p=1.000 n=6
Parse Time 7.52s (± 0.77%) 7.49s (± 0.72%) ~ 7.42s 7.57s p=0.230 n=6
Bind Time 2.79s (± 0.95%) 2.80s (± 0.98%) ~ 2.78s 2.85s p=0.808 n=6
Check Time 49.70s (± 0.61%) 49.54s (± 0.77%) ~ 49.12s 50.20s p=0.521 n=6
Emit Time 3.89s (± 3.77%) 3.94s (± 6.32%) ~ 3.71s 4.42s p=0.873 n=6
Total Time 63.92s (± 0.51%) 63.78s (± 0.72%) ~ 63.22s 64.43s p=0.575 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,229,666 1,229,706 +40 (+ 0.00%) ~ ~ p=0.001 n=6
Types 260,899 260,911 +12 (+ 0.00%) ~ ~ p=0.001 n=6
Memory used 2,502,761k (± 3.34%) 2,477,259k (± 3.16%) ~ 2,425,442k 2,578,894k p=0.575 n=6
Parse Time 5.17s (± 1.20%) 5.16s (± 0.74%) ~ 5.10s 5.21s p=0.873 n=6
Bind Time 1.68s (± 0.49%) 1.68s (± 0.70%) ~ 1.66s 1.69s p=0.738 n=6
Check Time 34.42s (± 0.17%) 34.35s (± 0.37%) ~ 34.11s 34.44s p=0.261 n=6
Emit Time 2.58s (± 2.23%) 2.61s (± 3.24%) ~ 2.51s 2.74s p=0.689 n=6
Total Time 43.86s (± 0.25%) 43.81s (± 0.44%) ~ 43.48s 44.05s p=0.810 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 258,551 258,591 +40 (+ 0.02%) ~ ~ p=0.001 n=6
Types 105,006 105,018 +12 (+ 0.01%) ~ ~ p=0.001 n=6
Memory used 428,129k (± 0.01%) 428,274k (± 0.02%) +146k (+ 0.03%) 428,204k 428,453k p=0.008 n=6
Parse Time 2.73s (± 0.54%) 2.75s (± 0.56%) ~ 2.73s 2.77s p=0.102 n=6
Bind Time 1.10s (± 1.41%) 1.10s (± 1.21%) ~ 1.09s 1.12s p=0.865 n=6
Check Time 15.37s (± 0.50%) 15.36s (± 0.47%) ~ 15.27s 15.45s p=0.936 n=6
Emit Time 1.14s (± 0.66%) 1.16s (± 1.93%) ~ 1.12s 1.18s p=0.062 n=6
Total Time 20.35s (± 0.49%) 20.38s (± 0.39%) ~ 20.30s 20.51s p=0.470 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 35 35 ~ ~ ~ p=1.000 n=6
Symbols 224,565 224,565 ~ ~ ~ p=1.000 n=6
Types 93,734 93,734 ~ ~ ~ p=1.000 n=6
Memory used 369,866k (± 0.03%) 369,822k (± 0.02%) ~ 369,725k 369,933k p=0.471 n=6
Parse Time 3.49s (± 0.35%) 3.52s (± 0.70%) +0.03s (+ 0.72%) 3.49s 3.56s p=0.050 n=6
Bind Time 1.97s (± 1.19%) 1.93s (± 1.26%) -0.04s (- 2.12%) 1.89s 1.95s p=0.015 n=6
Check Time 19.41s (± 0.15%) 19.36s (± 0.41%) ~ 19.25s 19.47s p=0.259 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 24.87s (± 0.12%) 24.80s (± 0.28%) ~ 24.71s 24.89s p=0.090 n=6
vscode - node (v18.15.0, x64)
Errors 10 10 ~ ~ ~ p=1.000 n=6
Symbols 2,842,923 2,842,923 ~ ~ ~ p=1.000 n=6
Types 963,434 963,434 ~ ~ ~ p=1.000 n=6
Memory used 3,015,788k (± 0.00%) 3,015,749k (± 0.00%) ~ 3,015,672k 3,015,809k p=0.261 n=6
Parse Time 13.84s (± 0.37%) 13.81s (± 0.19%) ~ 13.77s 13.85s p=0.627 n=6
Bind Time 4.17s (± 0.15%) 4.20s (± 1.91%) ~ 4.15s 4.36s p=0.802 n=6
Check Time 73.27s (± 0.23%) 73.36s (± 0.53%) ~ 73.12s 74.14s p=0.936 n=6
Emit Time 23.67s (± 0.64%) 23.61s (± 0.32%) ~ 23.49s 23.69s p=0.520 n=6
Total Time 114.94s (± 0.25%) 114.98s (± 0.30%) ~ 114.70s 115.66s p=0.521 n=6
webpack - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 266,361 266,361 ~ ~ ~ p=1.000 n=6
Types 108,554 108,554 ~ ~ ~ p=1.000 n=6
Memory used 411,273k (± 0.00%) 411,308k (± 0.02%) ~ 411,207k 411,377k p=0.298 n=6
Parse Time 3.85s (± 0.70%) 3.83s (± 0.59%) ~ 3.82s 3.88s p=0.354 n=6
Bind Time 1.66s (± 1.10%) 1.67s (± 0.31%) ~ 1.66s 1.67s p=0.548 n=6
Check Time 17.00s (± 0.16%) 17.00s (± 0.43%) ~ 16.93s 17.10s p=0.468 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 22.52s (± 0.21%) 22.50s (± 0.28%) ~ 22.44s 22.60s p=0.629 n=6
xstate-main - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 525,588 525,588 ~ ~ ~ p=1.000 n=6
Types 179,032 179,032 ~ ~ ~ p=1.000 n=6
Memory used 462,968k (± 0.04%) 463,259k (± 0.08%) ~ 462,840k 463,635k p=0.261 n=6
Parse Time 3.14s (± 0.90%) 3.15s (± 0.81%) ~ 3.12s 3.19s p=0.418 n=6
Bind Time 1.19s (± 0.34%) 1.18s (± 0.44%) -0.01s (- 0.70%) 1.18s 1.19s p=0.022 n=6
Check Time 18.07s (± 0.47%) 18.11s (± 0.51%) ~ 17.95s 18.22s p=0.260 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 22.40s (± 0.30%) 22.45s (± 0.45%) ~ 22.28s 22.57s p=0.261 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

tsserver

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 3,418ms (± 0.57%) 3,420ms (± 0.20%) ~ 3,407ms 3,428ms p=0.628 n=6
Req 2 - geterr 7,569ms (± 0.44%) 7,594ms (± 0.51%) ~ 7,549ms 7,653ms p=0.471 n=6
Req 3 - references 434ms (± 1.20%) 433ms (± 1.48%) ~ 423ms 441ms p=0.936 n=6
Req 4 - navto 340ms (± 0.71%) 341ms (± 1.85%) ~ 334ms 353ms p=0.868 n=6
Req 5 - completionInfo count 1,357 1,357 ~ ~ ~ p=1.000 n=6
Req 5 - completionInfo 117ms (± 8.17%) 116ms (± 4.65%) ~ 111ms 125ms p=0.627 n=6
CompilerTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 3,605ms (± 0.45%) 3,618ms (± 0.25%) ~ 3,602ms 3,626ms p=0.090 n=6
Req 2 - geterr 5,705ms (± 0.45%) 5,714ms (± 0.20%) ~ 5,701ms 5,728ms p=0.936 n=6
Req 3 - references 449ms (± 0.82%) 449ms (± 0.97%) ~ 444ms 456ms p=0.871 n=6
Req 4 - navto 342ms (± 1.54%) 345ms (± 1.52%) ~ 341ms 352ms p=0.157 n=6
Req 5 - completionInfo count 1,519 1,519 ~ ~ ~ p=1.000 n=6
Req 5 - completionInfo 117ms (± 8.31%) 117ms (± 7.84%) ~ 107ms 125ms p=1.000 n=6
xstate-main-1-tsserver - node (v18.15.0, x64)
Req 1 - updateOpen 6,117ms (± 0.55%) 6,141ms (± 0.36%) ~ 6,115ms 6,165ms p=0.229 n=6
Req 2 - geterr 1,361ms (± 1.85%) 1,355ms (± 1.02%) ~ 1,343ms 1,380ms p=0.810 n=6
Req 3 - references 115ms (± 6.04%) 113ms (± 3.64%) ~ 109ms 118ms p=0.366 n=6
Req 4 - navto 534ms (± 6.92%) 524ms (± 7.52%) ~ 496ms 588ms p=0.630 n=6
Req 5 - completionInfo count 3,413 3,413 ~ ~ ~ p=1.000 n=6
Req 5 - completionInfo 1,075ms (± 9.25%) 1,057ms (±11.61%) ~ 986ms 1,306ms p=0.297 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • CompilerTSServer - node (v18.15.0, x64)
  • Compiler-UnionsTSServer - node (v18.15.0, x64)
  • xstate-main-1-tsserver - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

startup

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
tsc-startup - node (v18.15.0, x64)
Execution time 187.86ms (± 0.15%) 187.50ms (± 0.15%) -0.35ms (- 0.19%) 186.09ms 191.31ms p=0.000 n=600
tsserver-startup - node (v18.15.0, x64)
Execution time 360.95ms (± 0.26%) 361.33ms (± 0.27%) +0.38ms (+ 0.10%) 353.18ms 368.84ms p=0.000 n=600
tsserverlibrary-startup - node (v18.15.0, x64)
Execution time 287.28ms (± 0.27%) 287.08ms (± 0.27%) -0.20ms (- 0.07%) 280.39ms 290.56ms p=0.000 n=600
typescript-startup - node (v18.15.0, x64)
Execution time 288.08ms (± 0.29%) 288.03ms (± 0.28%) ~ 280.81ms 294.41ms p=0.225 n=600
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • tsc-startup - node (v18.15.0, x64)
  • tsserver-startup - node (v18.15.0, x64)
  • tsserverlibrary-startup - node (v18.15.0, x64)
  • typescript-startup - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@weswigham
Copy link
Member Author

@jakebailey I've minimized the diff (and swapped them all to only improvements) by adding a small change to explicitly add positions for type parameter names. I think the original change caused us to stop attaching positions to them spuriously, and now we actually do it explicitly, so there's a smaller diff, but there is a diff of parameter names where we now actually have locations. Also a fourslash test update that shows a new comment getting preserved.

jakebailey
jakebailey reviewed May 31, 2024
View reviewed changes
tests/cases/compiler/declarationEmitTopLevelNodeFromCrossFile.ts
Comment on lines +7 to +16
import {fn} from "./a";
export const m = {
/**
* leading doc for prop
*/
prop: 1
}


export const x = { p: fn };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test doesn't seem like it tests #58698; am I missing something?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, maybe I'm just wrong given the issue was about pulling comments from other files, yeah.

@jakebailey
Copy link
Member

@typescript-bot perf test this faster

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 31, 2024 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
perf test this faster ✅ Started 👀 Results

jakebailey
jakebailey approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming perf remains unchanged.

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 30 30 ~ ~ ~ p=1.000 n=6
Symbols 62,153 62,153 ~ ~ ~ p=1.000 n=6
Types 50,242 50,242 ~ ~ ~ p=1.000 n=6
Memory used 193,601k (± 0.94%) 193,543k (± 0.98%) ~ 192,298k 196,074k p=0.688 n=6
Parse Time 1.31s (± 0.62%) 1.30s (± 0.58%) ~ 1.29s 1.31s p=0.206 n=6
Bind Time 0.72s 0.72s ~ ~ ~ p=1.000 n=6
Check Time 9.59s (± 0.39%) 9.58s (± 0.50%) ~ 9.53s 9.65s p=0.688 n=6
Emit Time 2.75s (± 0.42%) 2.76s (± 0.58%) ~ 2.74s 2.78s p=0.316 n=6
Total Time 14.36s (± 0.31%) 14.35s (± 0.33%) ~ 14.32s 14.44s p=0.936 n=6
angular-1 - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 944,109 944,109 ~ ~ ~ p=1.000 n=6
Types 407,049 407,049 ~ ~ ~ p=1.000 n=6
Memory used 1,222,175k (± 0.00%) 1,222,155k (± 0.01%) ~ 1,222,039k 1,222,250k p=0.471 n=6
Parse Time 8.07s (± 0.35%) 8.04s (± 0.39%) ~ 7.98s 8.06s p=0.122 n=6
Bind Time 2.22s (± 0.53%) 2.23s (± 0.52%) ~ 2.21s 2.24s p=0.365 n=6
Check Time 36.25s (± 0.31%) 36.26s (± 0.33%) ~ 36.07s 36.41s p=0.936 n=6
Emit Time 18.10s (± 0.62%) 18.02s (± 0.44%) ~ 17.91s 18.14s p=0.229 n=6
Total Time 64.64s (± 0.16%) 64.55s (± 0.27%) ~ 64.31s 64.82s p=0.572 n=6
mui-docs - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 2,051,460 2,051,460 ~ ~ ~ p=1.000 n=6
Types 899,446 899,446 ~ ~ ~ p=1.000 n=6
Memory used 2,065,705k (± 0.01%) 2,065,648k (± 0.01%) ~ 2,065,488k 2,065,811k p=0.298 n=6
Parse Time 8.10s (± 0.23%) 8.08s (± 0.22%) ~ 8.06s 8.11s p=0.121 n=6
Bind Time 2.74s (± 0.74%) 2.75s (± 1.23%) ~ 2.70s 2.79s p=0.935 n=6
Check Time 81.94s (± 0.58%) 82.18s (± 0.39%) ~ 81.76s 82.46s p=0.332 n=6
Emit Time 0.17s (± 3.32%) 0.17s (± 2.42%) ~ 0.16s 0.17s p=0.282 n=6
Total Time 92.95s (± 0.52%) 93.18s (± 0.34%) ~ 92.76s 93.51s p=0.378 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,229,666 1,229,707 +41 (+ 0.00%) ~ ~ p=0.001 n=6
Types 260,892 260,904 +12 (+ 0.00%) ~ ~ p=0.001 n=6
Memory used 2,402,475k (± 3.26%) 2,351,996k (± 0.04%) ~ 2,350,837k 2,353,107k p=0.378 n=6
Parse Time 7.46s (± 0.90%) 7.42s (± 0.76%) ~ 7.37s 7.51s p=0.336 n=6
Bind Time 2.80s (± 0.90%) 2.82s (± 0.35%) ~ 2.81s 2.83s p=0.195 n=6
Check Time 49.45s (± 0.41%) 49.61s (± 0.65%) ~ 49.18s 50.18s p=0.471 n=6
Emit Time 3.76s (± 4.56%) 3.80s (± 2.17%) ~ 3.68s 3.92s p=0.230 n=6
Total Time 63.48s (± 0.63%) 63.67s (± 0.56%) ~ 63.29s 64.33s p=0.378 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,229,666 1,229,707 +41 (+ 0.00%) ~ ~ p=0.001 n=6
Types 260,892 260,904 +12 (+ 0.00%) ~ ~ p=0.001 n=6
Memory used 2,478,063k (± 3.14%) 2,478,139k (± 3.13%) ~ 2,426,955k 2,579,274k p=0.936 n=6
Parse Time 6.24s (± 0.52%) 6.25s (± 0.41%) ~ 6.21s 6.29s p=0.873 n=6
Bind Time 2.01s (± 0.81%) 2.02s (± 0.75%) ~ 1.99s 2.03s p=0.462 n=6
Check Time 40.50s (± 0.21%) 40.47s (± 0.27%) ~ 40.34s 40.62s p=0.470 n=6
Emit Time 3.02s (± 2.57%) 3.06s (± 2.49%) ~ 2.99s 3.20s p=0.423 n=6
Total Time 51.79s (± 0.25%) 51.82s (± 0.30%) ~ 51.65s 52.00s p=1.000 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 258,551 258,592 +41 (+ 0.02%) ~ ~ p=0.001 n=6
Types 104,999 105,011 +12 (+ 0.01%) ~ ~ p=0.001 n=6
Memory used 428,176k (± 0.02%) 428,239k (± 0.01%) ~ 428,212k 428,280k p=0.199 n=6
Parse Time 4.08s (± 0.59%) 4.08s (± 0.48%) ~ 4.06s 4.11s p=0.570 n=6
Bind Time 1.62s (± 1.39%) 1.63s (± 1.62%) ~ 1.58s 1.65s p=0.627 n=6
Check Time 22.42s (± 0.42%) 22.40s (± 0.43%) ~ 22.31s 22.57s p=0.687 n=6
Emit Time 1.69s (± 1.10%) 1.71s (± 1.13%) ~ 1.68s 1.73s p=0.106 n=6
Total Time 29.80s (± 0.29%) 29.82s (± 0.31%) ~ 29.69s 29.97s p=0.748 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 35 35 ~ ~ ~ p=1.000 n=6
Symbols 224,565 224,565 ~ ~ ~ p=1.000 n=6
Types 93,734 93,734 ~ ~ ~ p=1.000 n=6
Memory used 369,873k (± 0.02%) 369,766k (± 0.02%) -107k (- 0.03%) 369,690k 369,854k p=0.045 n=6
Parse Time 3.51s (± 0.59%) 3.49s (± 0.49%) ~ 3.47s 3.52s p=0.121 n=6
Bind Time 1.94s (± 0.95%) 1.94s (± 0.89%) ~ 1.91s 1.96s p=0.569 n=6
Check Time 19.41s (± 0.41%) 19.42s (± 0.24%) ~ 19.36s 19.47s p=0.574 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 24.85s (± 0.26%) 24.85s (± 0.22%) ~ 24.76s 24.89s p=0.686 n=6
vscode - node (v18.15.0, x64)
Errors 10 10 ~ ~ ~ p=1.000 n=6
Symbols 2,843,069 2,843,069 ~ ~ ~ p=1.000 n=6
Types 963,472 963,472 ~ ~ ~ p=1.000 n=6
Memory used 3,015,828k (± 0.00%) 3,015,850k (± 0.00%) ~ 3,015,765k 3,015,928k p=0.575 n=6
Parse Time 13.86s (± 0.36%) 13.85s (± 0.23%) ~ 13.82s 13.89s p=1.000 n=6
Bind Time 4.21s (± 2.19%) 4.19s (± 2.32%) ~ 4.14s 4.39s p=0.357 n=6
Check Time 73.78s (± 1.93%) 73.95s (± 2.06%) ~ 72.84s 77.00s p=0.471 n=6
Emit Time 22.99s (± 6.51%) 23.02s (± 6.45%) ~ 20.00s 23.90s p=1.000 n=6
Total Time 114.83s (± 0.23%) 115.01s (± 0.36%) ~ 114.37s 115.46s p=0.378 n=6
webpack - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 266,361 266,361 ~ ~ ~ p=1.000 n=6
Types 108,554 108,554 ~ ~ ~ p=1.000 n=6
Memory used 411,489k (± 0.02%) 411,433k (± 0.02%) ~ 411,363k 411,568k p=0.378 n=6
Parse Time 4.78s (± 1.04%) 4.77s (± 0.68%) ~ 4.74s 4.83s p=0.872 n=6
Bind Time 2.08s (± 0.79%) 2.08s (± 0.61%) ~ 2.07s 2.10s p=0.567 n=6
Check Time 21.20s (± 0.53%) 21.08s (± 0.25%) ~ 21.02s 21.16s p=0.063 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 28.07s (± 0.29%) 27.92s (± 0.21%) -0.14s (- 0.51%) 27.84s 28.00s p=0.020 n=6
xstate-main - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 525,588 525,588 ~ ~ ~ p=1.000 n=6
Types 179,032 179,032 ~ ~ ~ p=1.000 n=6
Memory used 463,316k (± 0.07%) 463,353k (± 0.08%) ~ 462,839k 463,657k p=0.873 n=6
Parse Time 2.62s (± 0.31%) 2.62s (± 0.24%) ~ 2.61s 2.63s p=0.599 n=6
Bind Time 0.99s (± 0.52%) 0.99s (± 0.52%) ~ 0.99s 1.00s p=1.000 n=6
Check Time 15.23s (± 0.58%) 15.24s (± 0.40%) ~ 15.14s 15.33s p=0.568 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 18.85s (± 0.43%) 18.85s (± 0.31%) ~ 18.75s 18.93s p=0.419 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@weswigham weswigham merged commit d4976c0 into microsoft:main May 31, 2024
28 checks passed
skeate added a commit to skeate/TypeScript that referenced this pull request Jun 1, 2024
@skeate
Merge remote-tracking branch 'upstream/main'
9fc6c04 
* upstream/main: (37 commits)
  Added NoTruncation flag to completions (microsoft#58719)
  Clone node to remove location even when it has been modified if needed (microsoft#58706)
  Properly account for `this` argument in intersection apparent type caching (microsoft#58677)
  Fix: Include Values of Script Extensions for Unicode Property Value Expressions in Regular Expressions (microsoft#58615)
  In `reScanSlashToken` use `charCodeChecked` not `codePointChecked` (microsoft#58727)
  Shorten error spans for errors reported on constructor declarations (microsoft#58061)
  Mark file as skips typechecking if it contains ts-nocheck (microsoft#58593)
  Fixed an issue with broken `await using` declarations in `for of` loops (microsoft#56466)
  Do not expand type references in keyof and index access (microsoft#58715)
  Improve the performance of isolatedDeclarations quickfix  (microsoft#58722)
  Unwrap `NoInfer` types when narrowing (microsoft#58292)
  Recover from type reuse errors by falling back to inferred type printing (microsoft#58720)
  Fixing self import (microsoft#58718)
  Enable JS emit for noCheck and noCheck for transpileModule (microsoft#58364)
  Revert PR 55371 (microsoft#58702)
  Update dependencies (microsoft#58639)
  Fix baselines after PR 58621 (microsoft#58705)
  Do not infer `yield*` type from contextual `TReturn` (microsoft#58621)
  `await using` normative changes (microsoft#58624)
  Handling statements from a known source file (microsoft#58679)
  ...
@fatcerberus fatcerberus mentioned this pull request Jun 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

Assignees

@weswigham weswigham

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TS5.5-beta injects a random @ts-expect-error comment in the generated .d.ts files
3 participants
@weswigham @jakebailey @typescript-bot