Handling statements from a known source file #58679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
src/services/pasteEdits.ts
Outdated
| const statementsInSourceFile = copiedFrom.file.statements; | ||
| const startNodeIndex = findIndex(statementsInSourceFile, s => s.end > copy.pos); | ||
| if (startNodeIndex === -1) return undefined; | ||
| const endNodeIndex = findIndex(statementsInSourceFile, s => s.end >= copy.end, startNodeIndex); |
There was a problem hiding this comment.
This includes the next statement if the end of the selection includes any leading trivia of the next statement:
// both statements get added to `statements`:
[|console.log(a);
|]
console.log(b);
andrewbranch
approved these changes
May 29, 2024
Comment on lines
+88
to
+90
| if (endNodeIndex !== -1 && copy.end <= statementsInSourceFile[endNodeIndex].getStart()) { | ||
| endNodeIndex--; | ||
| } |
There was a problem hiding this comment.
I think this could be baked into the findIndex predicate, but this is alright.
skeate
added a commit
to skeate/TypeScript
that referenced
this pull request
Jun 1, 2024
* upstream/main: (37 commits) Added NoTruncation flag to completions (microsoft#58719) Clone node to remove location even when it has been modified if needed (microsoft#58706) Properly account for `this` argument in intersection apparent type caching (microsoft#58677) Fix: Include Values of Script Extensions for Unicode Property Value Expressions in Regular Expressions (microsoft#58615) In `reScanSlashToken` use `charCodeChecked` not `codePointChecked` (microsoft#58727) Shorten error spans for errors reported on constructor declarations (microsoft#58061) Mark file as skips typechecking if it contains ts-nocheck (microsoft#58593) Fixed an issue with broken `await using` declarations in `for of` loops (microsoft#56466) Do not expand type references in keyof and index access (microsoft#58715) Improve the performance of isolatedDeclarations quickfix (microsoft#58722) Unwrap `NoInfer` types when narrowing (microsoft#58292) Recover from type reuse errors by falling back to inferred type printing (microsoft#58720) Fixing self import (microsoft#58718) Enable JS emit for noCheck and noCheck for transpileModule (microsoft#58364) Revert PR 55371 (microsoft#58702) Update dependencies (microsoft#58639) Fix baselines after PR 58621 (microsoft#58705) Do not infer `yield*` type from contextual `TReturn` (microsoft#58621) `await using` normative changes (microsoft#58624) Handling statements from a known source file (microsoft#58679) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing copy/paste functionality, it was found that imports were not getting adding from a file. The reason behind this was because the right statements were not getting extracted from the
copiedFromfile. Whenever there was a newline, the line number and position would cause a problem in extracting the statements. This pr fixes that problem.