Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly account for this argument in intersection apparent type caching #58677

Merged
merged 3 commits into from
May 31, 2024
Merged

Properly account for this argument in intersection apparent type caching #58677

merged 3 commits into from
May 31, 2024

Conversation

ahejlsberg
Copy link
Member

Fixes #58175.

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels May 28, 2024
@ahejlsberg
Copy link
Member Author

Will add regression tests later today.

@ahejlsberg
Copy link
Member Author

@typescript-bot test it

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 28, 2024 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started ✅ Results
user test this ✅ Started ✅ Results
run dt ✅ Started ✅ Results
perf test this faster ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

Hey @ahejlsberg, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

@typescript-bot
Copy link
Collaborator

@ahejlsberg Here are the results of running the user tests comparing main and refs/pull/58677/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 30 30 ~ ~ ~ p=1.000 n=6
Symbols 62,154 62,154 ~ ~ ~ p=1.000 n=6
Types 50,248 50,248 ~ ~ ~ p=1.000 n=6
Memory used 192,997k (± 0.76%) 193,462k (± 0.96%) ~ 192,222k 195,907k p=1.000 n=6
Parse Time 1.30s (± 0.42%) 1.30s (± 0.69%) ~ 1.29s 1.31s p=0.341 n=6
Bind Time 0.72s 0.72s ~ ~ ~ p=1.000 n=6
Check Time 9.58s (± 0.56%) 9.55s (± 0.35%) ~ 9.51s 9.60s p=0.377 n=6
Emit Time 2.64s (± 0.75%) 2.63s (± 1.19%) ~ 2.60s 2.69s p=0.370 n=6
Total Time 14.24s (± 0.40%) 14.20s (± 0.28%) ~ 14.15s 14.25s p=0.334 n=6
angular-1 - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 944,110 944,110 ~ ~ ~ p=1.000 n=6
Types 407,140 407,140 ~ ~ ~ p=1.000 n=6
Memory used 1,222,052k (± 0.00%) 1,222,120k (± 0.00%) +69k (+ 0.01%) 1,222,058k 1,222,161k p=0.013 n=6
Parse Time 6.78s (± 0.78%) 6.78s (± 0.56%) ~ 6.75s 6.85s p=1.000 n=6
Bind Time 1.88s (± 0.45%) 1.87s (± 0.55%) ~ 1.86s 1.89s p=0.672 n=6
Check Time 31.35s (± 0.20%) 31.43s (± 0.47%) ~ 31.23s 31.64s p=0.377 n=6
Emit Time 14.73s (± 0.38%) 14.70s (± 0.73%) ~ 14.51s 14.78s p=0.810 n=6
Total Time 54.74s (± 0.14%) 54.78s (± 0.38%) ~ 54.49s 55.04s p=0.810 n=6
mui-docs - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 1,983,044 1,983,044 ~ ~ ~ p=1.000 n=6
Types 881,266 881,266 ~ ~ ~ p=1.000 n=6
Memory used 1,888,244k (± 0.00%) 1,888,993k (± 0.00%) +749k (+ 0.04%) 1,888,939k 1,889,103k p=0.005 n=6
Parse Time 6.82s (± 0.39%) 6.83s (± 0.40%) ~ 6.79s 6.87s p=0.570 n=6
Bind Time 2.27s (± 0.96%) 2.30s (± 0.85%) +0.03s (+ 1.47%) 2.27s 2.32s p=0.032 n=6
Check Time 60.53s (± 0.24%) 61.20s (± 0.38%) +0.67s (+ 1.11%) 60.99s 61.52s p=0.005 n=6
Emit Time 0.14s 0.14s ~ ~ ~ p=1.000 n=6
Total Time 69.76s (± 0.22%) 70.47s (± 0.34%) +0.71s (+ 1.02%) 70.24s 70.79s p=0.005 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,226,341 1,226,342 +1 (+ 0.00%) ~ ~ p=0.001 n=6
Types 260,978 260,978 ~ ~ ~ p=1.000 n=6
Memory used 2,368,829k (± 2.59%) 2,342,955k (± 0.05%) ~ 2,341,929k 2,345,240k p=0.093 n=6
Parse Time 4.98s (± 0.66%) 5.00s (± 0.77%) ~ 4.96s 5.06s p=0.630 n=6
Bind Time 1.92s (± 0.77%) 1.92s (± 0.63%) ~ 1.90s 1.93s p=0.739 n=6
Check Time 33.85s (± 0.30%) 33.89s (± 0.31%) ~ 33.75s 34.07s p=0.689 n=6
Emit Time 2.58s (± 3.01%) 2.66s (± 5.50%) ~ 2.48s 2.89s p=0.471 n=6
Total Time 43.32s (± 0.26%) 43.49s (± 0.48%) ~ 43.15s 43.74s p=0.173 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,226,341 1,226,342 +1 (+ 0.00%) ~ ~ p=0.001 n=6
Types 260,978 260,978 ~ ~ ~ p=1.000 n=6
Memory used 2,470,505k (± 3.13%) 2,444,973k (± 2.52%) ~ 2,418,164k 2,570,928k p=0.298 n=6
Parse Time 6.23s (± 0.85%) 6.23s (± 0.75%) ~ 6.15s 6.28s p=0.936 n=6
Bind Time 2.06s (± 0.91%) 2.05s (± 0.57%) ~ 2.04s 2.07s p=0.290 n=6
Check Time 40.35s (± 0.24%) 40.37s (± 0.26%) ~ 40.26s 40.51s p=1.000 n=6
Emit Time 3.02s (± 2.41%) 3.12s (± 5.08%) ~ 2.96s 3.38s p=0.229 n=6
Total Time 51.66s (± 0.29%) 51.80s (± 0.35%) ~ 51.66s 52.07s p=0.128 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 258,038 258,039 +1 (+ 0.00%) ~ ~ p=0.001 n=6
Types 104,984 104,984 ~ ~ ~ p=1.000 n=6
Memory used 426,928k (± 0.02%) 427,122k (± 0.02%) +194k (+ 0.05%) 426,995k 427,297k p=0.013 n=6
Parse Time 4.13s (± 0.36%) 4.13s (± 0.68%) ~ 4.08s 4.16s p=1.000 n=6
Bind Time 1.61s (± 0.85%) 1.64s (± 1.14%) ~ 1.60s 1.65s p=0.053 n=6
Check Time 22.31s (± 0.35%) 22.36s (± 0.18%) ~ 22.31s 22.40s p=0.333 n=6
Emit Time 1.71s (± 1.21%) 1.68s (± 2.04%) ~ 1.65s 1.73s p=0.228 n=6
Total Time 29.76s (± 0.34%) 29.80s (± 0.14%) ~ 29.76s 29.86s p=0.297 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 35 35 ~ ~ ~ p=1.000 n=6
Symbols 224,575 224,575 ~ ~ ~ p=1.000 n=6
Types 93,785 93,785 ~ ~ ~ p=1.000 n=6
Memory used 369,930k (± 0.04%) 369,854k (± 0.04%) ~ 369,712k 370,066k p=0.298 n=6
Parse Time 2.82s (± 1.16%) 2.83s (± 0.89%) ~ 2.79s 2.86s p=0.871 n=6
Bind Time 1.58s (± 0.48%) 1.58s (± 0.57%) ~ 1.57s 1.59s p=0.798 n=6
Check Time 15.64s (± 0.35%) 15.62s (± 0.37%) ~ 15.53s 15.71s p=0.258 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 20.04s (± 0.22%) 20.02s (± 0.34%) ~ 19.97s 20.15s p=0.421 n=6
vscode - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,840,563 2,840,563 ~ ~ ~ p=1.000 n=6
Types 963,163 963,163 ~ ~ ~ p=1.000 n=6
Memory used 3,013,875k (± 0.00%) 3,013,863k (± 0.00%) ~ 3,013,784k 3,013,947k p=1.000 n=6
Parse Time 17.00s (± 0.38%) 16.98s (± 0.51%) ~ 16.90s 17.11s p=0.228 n=6
Bind Time 5.14s (± 2.42%) 5.14s (± 2.21%) ~ 5.02s 5.27s p=1.000 n=6
Check Time 88.60s (± 0.27%) 88.76s (± 0.28%) ~ 88.53s 89.13s p=0.520 n=6
Emit Time 28.61s (± 0.50%) 28.57s (± 0.62%) ~ 28.31s 28.75s p=0.630 n=6
Total Time 139.35s (± 0.28%) 139.45s (± 0.28%) ~ 138.99s 139.95s p=0.936 n=6
webpack - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 266,087 266,087 ~ ~ ~ p=1.000 n=6
Types 108,518 108,518 ~ ~ ~ p=1.000 n=6
Memory used 410,922k (± 0.01%) 411,025k (± 0.03%) ~ 410,894k 411,201k p=0.173 n=6
Parse Time 4.78s (± 0.51%) 4.79s (± 0.54%) ~ 4.76s 4.83s p=0.627 n=6
Bind Time 2.06s (± 1.00%) 2.07s (± 0.56%) ~ 2.05s 2.08s p=0.934 n=6
Check Time 21.05s (± 0.34%) 21.16s (± 0.41%) +0.11s (+ 0.52%) 21.03s 21.29s p=0.043 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 27.90s (± 0.24%) 28.02s (± 0.35%) +0.12s (+ 0.44%) 27.86s 28.15s p=0.036 n=6
xstate-main - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 535,745 535,745 ~ ~ ~ p=1.000 n=6
Types 182,753 182,753 ~ ~ ~ p=1.000 n=6
Memory used 470,384k (± 0.00%) 470,488k (± 0.01%) +104k (+ 0.02%) 470,432k 470,590k p=0.005 n=6
Parse Time 3.18s (± 0.51%) 3.17s (± 0.51%) ~ 3.16s 3.20s p=0.737 n=6
Bind Time 1.21s (± 1.32%) 1.20s (± 0.43%) ~ 1.20s 1.21s p=0.923 n=6
Check Time 18.37s (± 0.32%) 18.39s (± 0.39%) ~ 18.31s 18.52s p=0.808 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 22.75s (± 0.30%) 22.76s (± 0.31%) ~ 22.69s 22.88s p=0.936 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

@ahejlsberg Here are the results of running the top 400 repos comparing main and refs/pull/58677/merge:

Everything looks good!

@ahejlsberg
Copy link
Member Author

@typescript-bot test it

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 28, 2024 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started ✅ Results
user test this ✅ Started ✅ Results
run dt ✅ Started ✅ Results
perf test this faster ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

Hey @ahejlsberg, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

@typescript-bot
Copy link
Collaborator

@ahejlsberg Here are the results of running the user tests comparing main and refs/pull/58677/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 30 30 ~ ~ ~ p=1.000 n=6
Symbols 62,153 62,153 ~ ~ ~ p=1.000 n=6
Types 50,242 50,242 ~ ~ ~ p=1.000 n=6
Memory used 192,831k (± 0.76%) 192,929k (± 0.73%) ~ 192,193k 195,799k p=0.810 n=6
Parse Time 1.31s (± 0.64%) 1.30s (± 0.76%) ~ 1.29s 1.31s p=0.256 n=6
Bind Time 0.72s (± 0.57%) 0.72s ~ ~ ~ p=0.405 n=6
Check Time 9.53s (± 0.28%) 9.54s (± 0.53%) ~ 9.46s 9.59s p=0.629 n=6
Emit Time 2.64s (± 0.59%) 2.64s (± 0.56%) ~ 2.62s 2.65s p=0.801 n=6
Total Time 14.20s (± 0.23%) 14.20s (± 0.43%) ~ 14.09s 14.25s p=0.810 n=6
angular-1 - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 944,105 944,105 ~ ~ ~ p=1.000 n=6
Types 407,032 407,032 ~ ~ ~ p=1.000 n=6
Memory used 1,221,992k (± 0.01%) 1,222,007k (± 0.01%) ~ 1,221,909k 1,222,080k p=0.936 n=6
Parse Time 8.12s (± 0.25%) 8.11s (± 0.39%) ~ 8.08s 8.16s p=0.684 n=6
Bind Time 2.23s (± 0.59%) 2.25s (± 0.56%) +0.02s (+ 0.82%) 2.23s 2.26s p=0.048 n=6
Check Time 36.47s (± 0.31%) 36.50s (± 0.45%) ~ 36.34s 36.73s p=0.936 n=6
Emit Time 17.56s (± 0.77%) 17.49s (± 0.42%) ~ 17.42s 17.60s p=0.295 n=6
Total Time 64.38s (± 0.29%) 64.36s (± 0.32%) ~ 64.14s 64.60s p=1.000 n=6
mui-docs - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 1,983,122 1,983,122 ~ ~ ~ p=1.000 n=6
Types 881,307 881,307 ~ ~ ~ p=1.000 n=6
Memory used 1,888,318k (± 0.00%) 1,888,351k (± 0.00%) ~ 1,888,313k 1,888,407k p=0.173 n=6
Parse Time 6.82s (± 0.36%) 6.83s (± 0.41%) ~ 6.79s 6.86s p=0.806 n=6
Bind Time 2.28s (± 1.22%) 2.29s (± 0.62%) ~ 2.27s 2.31s p=0.331 n=6
Check Time 60.37s (± 0.39%) 60.38s (± 0.46%) ~ 59.98s 60.79s p=0.936 n=6
Emit Time 0.14s (± 2.95%) 0.14s (± 2.95%) ~ 0.13s 0.14s p=1.000 n=6
Total Time 69.61s (± 0.33%) 69.63s (± 0.39%) ~ 69.22s 70.02s p=0.810 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,226,317 1,226,318 +1 (+ 0.00%) ~ ~ p=0.001 n=6
Types 260,840 260,840 ~ ~ ~ p=1.000 n=6
Memory used 2,418,465k (± 3.43%) 2,369,381k (± 2.61%) ~ 2,343,583k 2,495,921k p=0.810 n=6
Parse Time 7.42s (± 1.06%) 7.47s (± 1.22%) ~ 7.33s 7.60s p=0.378 n=6
Bind Time 2.78s (± 0.89%) 2.78s (± 0.54%) ~ 2.77s 2.81s p=1.000 n=6
Check Time 49.61s (± 1.19%) 49.28s (± 0.55%) ~ 48.85s 49.65s p=0.298 n=6
Emit Time 3.85s (± 3.55%) 3.83s (± 4.90%) ~ 3.69s 4.16s p=0.689 n=6
Total Time 63.68s (± 1.21%) 63.37s (± 0.77%) ~ 62.65s 63.93s p=0.298 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,226,317 1,226,318 +1 (+ 0.00%) ~ ~ p=0.001 n=6
Types 260,840 260,840 ~ ~ ~ p=1.000 n=6
Memory used 2,444,561k (± 2.51%) 2,419,247k (± 0.03%) ~ 2,418,304k 2,420,531k p=0.378 n=6
Parse Time 5.16s (± 1.07%) 5.17s (± 1.28%) ~ 5.11s 5.26s p=0.810 n=6
Bind Time 1.71s (± 1.01%) 1.70s (± 0.61%) ~ 1.69s 1.72s p=0.797 n=6
Check Time 34.32s (± 0.26%) 34.33s (± 0.28%) ~ 34.21s 34.48s p=0.936 n=6
Emit Time 2.59s (± 2.86%) 2.62s (± 1.92%) ~ 2.55s 2.70s p=0.521 n=6
Total Time 43.79s (± 0.32%) 43.84s (± 0.28%) ~ 43.72s 44.06s p=0.936 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 258,026 258,027 +1 (+ 0.00%) ~ ~ p=0.001 n=6
Types 104,904 104,904 ~ ~ ~ p=1.000 n=6
Memory used 426,927k (± 0.02%) 426,914k (± 0.01%) ~ 426,841k 426,969k p=0.936 n=6
Parse Time 3.32s (± 0.44%) 3.33s (± 1.48%) ~ 3.28s 3.40s p=0.809 n=6
Bind Time 1.32s (± 0.78%) 1.32s (± 1.33%) ~ 1.29s 1.33s p=0.803 n=6
Check Time 17.99s (± 0.51%) 17.98s (± 0.32%) ~ 17.87s 18.03s p=0.809 n=6
Emit Time 1.34s (± 1.60%) 1.34s (± 1.02%) ~ 1.33s 1.37s p=0.213 n=6
Total Time 23.98s (± 0.40%) 23.97s (± 0.21%) ~ 23.90s 24.03s p=0.810 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 35 35 ~ ~ ~ p=1.000 n=6
Symbols 224,565 224,565 ~ ~ ~ p=1.000 n=6
Types 93,734 93,734 ~ ~ ~ p=1.000 n=6
Memory used 369,862k (± 0.02%) 369,778k (± 0.02%) ~ 369,698k 369,879k p=0.066 n=6
Parse Time 2.36s (± 0.92%) 2.35s (± 1.02%) ~ 2.33s 2.39s p=0.461 n=6
Bind Time 1.33s (± 1.13%) 1.33s (± 0.91%) ~ 1.32s 1.35s p=0.402 n=6
Check Time 13.35s (± 0.48%) 13.33s (± 0.60%) ~ 13.22s 13.41s p=0.810 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 17.04s (± 0.34%) 17.00s (± 0.57%) ~ 16.88s 17.10s p=0.810 n=6
vscode - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,840,560 2,840,560 ~ ~ ~ p=1.000 n=6
Types 962,642 962,642 ~ ~ ~ p=1.000 n=6
Memory used 3,013,622k (± 0.00%) 3,013,618k (± 0.00%) ~ 3,013,563k 3,013,751k p=0.575 n=6
Parse Time 17.02s (± 0.30%) 17.07s (± 0.30%) ~ 16.97s 17.12s p=0.173 n=6
Bind Time 5.10s (± 1.77%) 5.10s (± 2.19%) ~ 5.03s 5.33s p=0.936 n=6
Check Time 90.04s (± 2.19%) 89.84s (± 2.20%) ~ 88.88s 93.88s p=0.575 n=6
Emit Time 28.00s (± 6.74%) 28.07s (± 6.92%) ~ 24.11s 29.02s p=0.575 n=6
Total Time 140.17s (± 0.22%) 140.09s (± 0.20%) ~ 139.75s 140.57s p=0.936 n=6
webpack - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 266,048 266,048 ~ ~ ~ p=1.000 n=6
Types 108,470 108,470 ~ ~ ~ p=1.000 n=6
Memory used 410,874k (± 0.02%) 410,833k (± 0.02%) ~ 410,757k 410,963k p=0.575 n=6
Parse Time 3.85s (± 0.31%) 3.85s (± 0.26%) ~ 3.84s 3.86s p=0.865 n=6
Bind Time 1.67s (± 0.83%) 1.67s (± 1.20%) ~ 1.64s 1.69s p=0.568 n=6
Check Time 17.03s (± 0.24%) 16.98s (± 0.39%) ~ 16.90s 17.09s p=0.148 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 22.55s (± 0.25%) 22.50s (± 0.26%) ~ 22.43s 22.61s p=0.172 n=6
xstate-main - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 535,743 535,743 ~ ~ ~ p=1.000 n=6
Types 182,738 182,738 ~ ~ ~ p=1.000 n=6
Memory used 470,440k (± 0.01%) 470,475k (± 0.02%) ~ 470,382k 470,564k p=0.471 n=6
Parse Time 3.95s (± 0.31%) 3.94s (± 0.69%) ~ 3.91s 3.97s p=0.806 n=6
Bind Time 1.49s (± 1.53%) 1.49s (± 0.71%) ~ 1.47s 1.50s p=0.415 n=6
Check Time 22.70s (± 0.66%) 22.67s (± 0.33%) ~ 22.56s 22.77s p=0.630 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 28.14s (± 0.50%) 28.09s (± 0.31%) ~ 27.95s 28.20s p=0.378 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@ahejlsberg
Copy link
Member Author

Tests are clean and performance is unaffected. I think this one is ready for review and merge.

@typescript-bot
Copy link
Collaborator

@ahejlsberg Here are the results of running the top 400 repos comparing main and refs/pull/58677/merge:

Everything looks good!

@ahejlsberg ahejlsberg merged commit 6c058d4 into main May 31, 2024
28 checks passed
@ahejlsberg ahejlsberg deleted the fix58175 branch May 31, 2024 21:45
skeate added a commit to skeate/TypeScript that referenced this pull request Jun 1, 2024
@skeate
Merge remote-tracking branch 'upstream/main'
9fc6c04 
* upstream/main: (37 commits)
  Added NoTruncation flag to completions (microsoft#58719)
  Clone node to remove location even when it has been modified if needed (microsoft#58706)
  Properly account for `this` argument in intersection apparent type caching (microsoft#58677)
  Fix: Include Values of Script Extensions for Unicode Property Value Expressions in Regular Expressions (microsoft#58615)
  In `reScanSlashToken` use `charCodeChecked` not `codePointChecked` (microsoft#58727)
  Shorten error spans for errors reported on constructor declarations (microsoft#58061)
  Mark file as skips typechecking if it contains ts-nocheck (microsoft#58593)
  Fixed an issue with broken `await using` declarations in `for of` loops (microsoft#56466)
  Do not expand type references in keyof and index access (microsoft#58715)
  Improve the performance of isolatedDeclarations quickfix  (microsoft#58722)
  Unwrap `NoInfer` types when narrowing (microsoft#58292)
  Recover from type reuse errors by falling back to inferred type printing (microsoft#58720)
  Fixing self import (microsoft#58718)
  Enable JS emit for noCheck and noCheck for transpileModule (microsoft#58364)
  Revert PR 55371 (microsoft#58702)
  Update dependencies (microsoft#58639)
  Fix baselines after PR 58621 (microsoft#58705)
  Do not infer `yield*` type from contextual `TReturn` (microsoft#58621)
  `await using` normative changes (microsoft#58624)
  Handling statements from a known source file (microsoft#58679)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@rbuckton rbuckton rbuckton approved these changes

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees

@ahejlsberg ahejlsberg

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent tsc behavior on TS 5.4
4 participants
@ahejlsberg @typescript-bot @DanielRosenwasser @rbuckton