This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
Updating report CI scripts to be more robust. #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v2 #581 +/- ##
=======================================
Coverage 86.57% 86.57%
=======================================
Files 119 119
Lines 3397 3397
Branches 584 584
=======================================
Hits 2941 2941
Misses 456 456Continue to review full report at Codecov.
|
mydiemho
approved these changes
Feb 15, 2019
wbreza
approved these changes
Feb 15, 2019
| @@ -4,7 +4,9 @@ const plato = require('es6-plato'); | |||
| // parse command line args | |||
| const optionDefinitions = [ | |||
| { name: 'src', type: String, defaultValue: './es6-src/**' }, | |||
| { name: 'output', type: String, defaultValue: './report' } | |||
| { name: 'output', type: String, defaultValue: './report' }, | |||
| { name: 'version', type: String, defaultValue: '2.0.0' }, | |||
There was a problem hiding this comment.
What is this 2.0.0 here? Is that VoTT version? If so can we pull out of package.json like you do above?
There was a problem hiding this comment.
Or is the the value only if version is not already supplied?
There was a problem hiding this comment.
just a default value, if one isn't passed in. yep, the calling script yanks this from package.json.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complexity CI is finally working end-to-end, retaining history for each merged PR.
Was able to test this e2e by pointing Azure DevOps to my branch.