fix: Tagging new region only applies to one region [AB#17176] #635
Conversation
tbarlow12
commented
Mar 4, 2019
tbarlow12
commented
- Canvas Helpers now returns clones of transformed tag arrays
- Canvas now allows CanvasTools to manage selected regions (removed from Canvas state)
- Fixing tag tests from editor page
…tag-keyboard-fix
Codecov Report
@@ Coverage Diff @@
## dev #635 +/- ##
==========================================
+ Coverage 86.46% 86.71% +0.25%
==========================================
Files 114 114
Lines 3523 3515 -8
Branches 612 607 -5
==========================================
+ Hits 3046 3048 +2
+ Misses 477 467 -10
Continue to review full report at Codecov.
|
tbarlow12
requested review from
mydiemho and
PIC123
and removed request for
mydiemho
tbarlow12
changed the title
| }, | ||
| )); | ||
| } | ||
|
|
There was a problem hiding this comment.
Why are you getting rid of this function?
There was a problem hiding this comment.
I think I moved it somewhere else... I'll look into it
| @@ -498,6 +501,27 @@ describe("Editor Page Component", () => { | |||
| dispatchKeyEvent("Ctrl+e"); | |||
| expect(clearRegions).toBeCalled(); | |||
| }); | |||
There was a problem hiding this comment.
Make sure you are up to date with the current dev branch. The Ctrl+e is related to the export provider and I don't know if this test is valid anymore.
There was a problem hiding this comment.
Good call. I'll make the change
There was a problem hiding this comment.
Good call. I'll make the change
Originally meant to fix a bug for hot keys applying the wrong tag to a region, but then discovered that the root cause was that each tag was being toggled on every region. If multiple tags were applied to multiple regions, it appeared that the wrong tag was being applied. Resolves [AB#17176]
