This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
fix: Ignore error from react drag n drop [AB#17466] #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydiemho
approved these changes
Mar 6, 2019
wbreza
reviewed
Mar 7, 2019
| @@ -77,6 +77,14 @@ export class ErrorHandler extends React.Component<IErrorHandlerProps> { | |||
| * @param error The error to handle | |||
| */ | |||
| private handleError(error: string | Error | AppError) { | |||
| // This is a special case where we don't need to throw an | |||
There was a problem hiding this comment.
Is there no way for us to catch this within the tags input component? Fix the underlying cause?
There was a problem hiding this comment.
It's thrown by the ReactDnD inside the tags input component we're using... My fix is the new tags input component. This is just the patch for the time being
PIC123
approved these changes
Mar 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReactDnD currently throws an error when tags are dragged. The operation still performs successfully, but throws the error anyway. This catches that specific error and ignores it