Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

doc: updating readme #733

Merged
merged 9 commits into from
Apr 12, 2019
Merged

doc: updating readme #733

merged 9 commits into from
Apr 12, 2019

Conversation

mydiemho
Copy link
Contributor

@mydiemho mydiemho commented Apr 9, 2019

going to hold on this until we flip over v2 -> master

Copy link
Contributor

@wbreza wbreza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine overall. Please address comments before merging.

CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@mydiemho mydiemho changed the title updating readme doc: updating readme Apr 10, 2019
Copy link
Contributor

@wbreza wbreza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please convert the images the JPG - the PNG's with many colors and lots going on are very large to show inline in a webpage. (3 & 6 MB)

@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #733 into dev-preview4 will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           dev-preview4     #733      +/-   ##
================================================
+ Coverage          86.9%   86.95%   +0.04%     
================================================
  Files               125      125              
  Lines              4345     4345              
  Branches            827      827              
================================================
+ Hits               3776     3778       +2     
+ Misses              567      565       -2     
  Partials              2        2
Impacted Files Coverage Δ
.../react/components/common/messageBox/messageBox.tsx 97.56% <0%> (+4.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ea0fe2...e585896. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #733 into dev-preview4 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           dev-preview4    #733   +/-   ##
============================================
  Coverage          86.9%   86.9%           
============================================
  Files               125     125           
  Lines              4345    4345           
  Branches            827     827           
============================================
  Hits               3776    3776           
  Misses              567     567           
  Partials              2       2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ea0fe2...dc5bb66. Read the comment docs.

@luisamiranda luisamiranda merged commit 575a233 into dev-preview4 Apr 12, 2019
wbreza pushed a commit that referenced this pull request Apr 12, 2019
* update Readme.md and Contributing.md
* remove markdown-toc
* new screenshots ( jpg )
* add mouse and keyboard shortcuts from vott-ct

#AB17930
@wbreza wbreza deleted the myho/docUpdate branch April 12, 2019 22:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants