[NSMutableArray removeObject:] does not remove all occurrences of an object in the array. #2771
Comments
DHowett-MSFT
pushed a commit
to DHowett-MSFT/WinObjC
that referenced
this issue
Jul 7, 2017
* removeObject:inRange: was originally finding the first instance of the object in the range, and then doing an array-wide search-and-remove every time it found one. This was very clearly wrong. This method was also augmented to do batch removals where possible. * removeObject: is supposed to remove every instance of the found object. It wasn't doing so. Fixes microsoft#2771. * removeObjectIdenticalTo: is supposed to remove every instance of the found object. It also wasn't doing so. * removeObjectIdenticalTo:inRange: wasn't implemented. * exchangeObjectAtIndex:withObjectAtIndex: was not using its CF optimized implementation. * Methods that mutated ranges were not bounds-checking those ranges.
DHowett-MSFT
pushed a commit
to DHowett-MSFT/WinObjC
that referenced
this issue
Jul 7, 2017
* removeObject:inRange: was originally finding the first instance of the object in the range, and then doing an array-wide search-and-remove every time it found one. This was very clearly wrong. * removeObject: is supposed to remove every instance of the found object. It wasn't doing so. Fixes microsoft#2771. * removeObjectIdenticalTo: is supposed to remove every instance of the found object. It also wasn't doing so. * removeObjectIdenticalTo:inRange: wasn't implemented. * exchangeObjectAtIndex:withObjectAtIndex: was not using its CF optimized implementation. * Methods that mutated ranges were not bounds-checking those ranges.
DHowett-MSFT
pushed a commit
that referenced
this issue
Jul 7, 2017
* removeObject:inRange: was originally finding the first instance of the object in the range, and then doing an array-wide search-and-remove every time it found one. This was very clearly wrong. * removeObject: is supposed to remove every instance of the found object. It wasn't doing so. Fixes #2771. * removeObjectIdenticalTo: is supposed to remove every instance of the found object. It also wasn't doing so. * removeObjectIdenticalTo:inRange: wasn't implemented. * exchangeObjectAtIndex:withObjectAtIndex: was not using its CF optimized implementation. * Methods that mutated ranges were not bounds-checking those ranges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
[NSMutableArray removeObject:]currently only removes the first occurrence of an object instance in the array. As per the reference platform, this method should remove all occurrences of an object instance in the array.The text was updated successfully, but these errors were encountered: