MddBootstrap Telemetry & TraceLogging #2321

sachintaMSFT · 2022-03-25T22:38:31Z

Telemetry and TraceLogging for MddBootstrap

sachintaMSFT · 2022-03-25T22:39:10Z

/azp run

azure-pipelines · 2022-03-25T22:39:21Z

Azure Pipelines successfully started running 1 pipeline(s).

riverar · 2022-03-25T23:22:54Z

Is the intention here to start adding telemetry to the bootstrap code/library? Will my apps start sending telemetry on initialize?

sachintaMSFT · 2022-03-26T01:07:03Z

Contributor

Yes. Add telemetry and also logging. Yes and only when client machine chooses privacy settings to Enhanced/Full telemetry. It's same as any WindowsAppRuntime component's telemetry.

dev/WindowsAppRuntime_BootstrapDLL/WindowsAppRuntime_BootstrapDLL.vcxproj.filters

DrusTheAxe

I think I'm missing something. This looks like telemetry support but I don't see where it's actively invoked. Or not these aren't WIL acctivities or remotely like them, it's WIL's fallback provider hook handling everything flowing through that?

dev/WindowsAppRuntime_BootstrapDLL/tracelogging.cpp

dev/WindowsAppRuntime_BootstrapDLL/tracelogging.h

sachintaMSFT · 2022-03-26T23:17:34Z

I think I'm missing something. This looks like telemetry support but I don't see where it's actively invoked. Or not these aren't WIL acctivities or remotely like them, it's WIL's fallback provider hook handling everything flowing through that?

Yes, the PR is half complete. Something weird happened when I pushed the PR (I changed the branch name before pushing and not sure if that had any weird impact to the push) and only half changes went in. Getting all up now.

sachintaMSFT · 2022-03-29T17:03:52Z

/azp run

azure-pipelines · 2022-03-29T17:03:57Z

Pull request contains merge conflicts.

sachintaMSFT · 2022-03-29T17:06:27Z

/azp run

azure-pipelines · 2022-03-29T17:06:41Z

Azure Pipelines successfully started running 1 pipeline(s).

dev/WindowsAppRuntime_BootstrapDLL/MddBootstrapActivity.h

dev/WindowsAppRuntime_BootstrapDLL/tracelogging.h

dev/WindowsAppRuntime_BootstrapDLL/MddBootstrap.cpp

sachintaMSFT · 2022-04-15T03:07:23Z

/azp run

azure-pipelines · 2022-04-15T03:07:27Z

Pull request contains merge conflicts.

dev/WindowsAppRuntime_BootstrapDLL/MddBootstrapActivity.cpp

dev/WindowsAppRuntime_BootstrapDLL/MddBootstrapActivity.h

dev/WindowsAppRuntime_BootstrapDLL/MddBootstrap.cpp

DrusTheAxe · 2022-04-15T04:57:26Z

dev/WindowsAppRuntime_BootstrapDLL/MddBootstrapActivity.h

        WindowsAppRuntimeBootstrap_TraceLogger::Initialize m_bootstrapInitializeActivity;
+        std::atomic<uint32_t> g_initializationCount;
+        wil::unique_cotaskmem_string g_initializationPackageFullName;


Do we ever need to know the value is null (vs empty)? At a glance it seems not so this could be std::wstring.

I think you had it as wil::unique_cotaskmem_string (which I maintianed) because IDynamicDependencyLifetimeManager's GetPackageFullName accepts LPWSTR and std::wstring return LPCWSTR. Do you have suggestion on elegant way to handle this ?

Ach. OK, so mote it be.

Nothing to see here. Move along. Nothing to see ;-)

dev/WindowsAppRuntime_BootstrapDLL/MddBootstrapActivity.h

sachintaMSFT · 2022-04-15T09:58:53Z

/azp run

azure-pipelines · 2022-04-15T09:59:05Z

Azure Pipelines successfully started running 1 pipeline(s).

sachintaMSFT · 2022-04-18T15:17:53Z

/azp run

azure-pipelines · 2022-04-18T15:18:05Z

Azure Pipelines successfully started running 1 pipeline(s).

…ult only when the activity is running.

sachintaMSFT · 2022-04-27T14:13:12Z

/azp run

azure-pipelines · 2022-04-27T14:13:24Z

Azure Pipelines successfully started running 1 pipeline(s).

DefaultRyan · 2022-04-29T19:31:39Z

dev/WindowsAppRuntime_BootstrapDLL/MddBootstrapActivity.cpp

+    return m_initializationCount;
+}
+
+const WindowsAppRuntime::MddBootstrap::Activity::IntegrityFlags& WindowsAppRuntime::MddBootstrap::Activity::Context::GetIntegrityFlags(HANDLE token)


You are returning a local variable by reference, which is undefined behavior. This has also triggered a build warning in the pipelines. Please fix.

* Rename CsWinRT Dependency Variable for Windows SDK * update Version.Details.xml * Under a .NET SDK version check, bring back our (broken) default file inclusion solution for RESW and image files (applies to non-single project MSIX apps only). (#2424) * Under a .NET SDK version check, continue to use our (broken) default file inclusion solution for RESW and image files (applies to non-single project MSIX apps only). * Fixes: use the right version number and use the right property for the version number! Tested. * add end dev library adoption section, link to community call (#2428) * Replace WAR_ prefix with WINDOWSAPPRUNTIME_ prefix (#2430) Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * Fix IsSelfContained() to lookup framework packagefamilyname at runtime (#2411) * Added Microsoft::WindowsAppRuntime::VersionInfo::RuntimeInformation as a (partial) runtime-equivalent WindowsAppSDK-VersionInfo.h to workaround the chicken-egg problem where we need to know the versioninfo now but it's nto defined until higher in the build tree (the Aggregator pipeline at the top) * Replaced WindowsAppRuntime_SelfContainedTestInitialize with WindowsAppRuntime_VersionInfo_TestInitialize as we moved the functionality down a level * Removed dead code * Update docs for IsSelfContained * Update test to match SelfContained/VersionInfo::TestInitialize change * Add missing #include * Fix compiler warnings (#2420) * Update WinRT contracts per specs\WinRT\WinRTAPIContracts.md (some contract names didn't match or were absent) * Fixed warnings * Use correct type to avoid warnings on some platform (#2436) Co-authored-by: Eric Langlois <erlangl@microsoft.com> * Trim Resource Id prefix from WINDOWSAPPRUNTIME_ to MSIX_ (#2442) Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * MddBootstrap Telemetry & TraceLogging (#2321) * MddBootStrap API telemetry * Use ThreadLoggingCallback instead of Process wide callback for wil result logging callback * Add safegaurds to call initialize and shutdown activity's StopWithResult only when the activity is running. Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * Update WindowsAppSDK-RunHelixTests-Job.yml (#2455) Appended windows.11.amd64.client.open.reunion to helixTargetQueuesOpen and Windows.11.Amd64.client.Reunion to helixTargetQueuesClosed. * UndockedRegFreeWinRT auto-initialization (#2452) * Remove dead code * Add URWF auto-initializer * New URFW files * Connect the dots for URFW auto-initialization support * Added missing file. Fixed compiler warnings * Simplified the C# auto-initializer. Added a comment explaining why it works the way it does * Updated C# auto-initializers to shortcircuit any work if loaded for reflecction (vs execution) * Added missing using * Fix returning a reference to a local variable in GetActivityFlags(); returns a const enum so no reason it can't be by-value and the obvious correctness reason it can't be by-ref * Added build macro WindowsAppSDKCleanIntermediateFiles=<boolean> to scrub intermediate outputs as we build. Defaults to 'true' for build pipeline else undefined and thus not acted on (e.g. dev inner-loop) * Fix prototype for GetIntegrityFlags * Move WindowsAppSDKCleanIntermediateFiles to be a parameter defined by the pipeline, for better inner-loop (for those who want to use the option) * Deploy Main and Singleton in BreakAway process when Deployment API is called from MediumILHigherIL Non-Microsoft publisher package (#2454) Create DeploymentAgent.exe and run it in a breakaway process from Deployment API when the caller is packaged process and has MediumIL/HigherIL integrity level. Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * Log Installer events to disk (#2460) * Log Installer events to disk (Application.evtx or Eventvwr.exe -> Windows Logs -> Application) in "WindowsAppRuntime Installer" source. Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * Change Singleton package Name to Microsoft.WinAppRuntime.Singleton[-shorttag] * Yet Moar CorpII * Replace WARmain with WARsingleton to point to singleton package * Update Deployment ACIDs in Framework package manifest (#2472) Update Deployment ACIDs in Framework package manifest Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * Fix UndockedRegFreeWinRT auto-initializer issues (#2476) * Fix bad filename * No precompiledheaders when compiling the auto-initializer * Copy DeploymentAgent executable to TestFwkPkg (#2467) * Copy DeploymentAgent executable to TestFwkPkg * Make DeploymentAgent a dependency to build Microsoft.Windows.Framework Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * Add PushNotificationsLongRunningTask.ProxyStub pdb to symbols dir (#2361) Co-authored-by: Eric Langlois <erlangl@microsoft.com> * Some refinements on the UndockedRegFreeWinRT self-contained and auto-initialization support (#2493) Co-authored-by: Joshua Larkin <70237359+j0shuams@users.noreply.github.com> Co-authored-by: Rohan Palaniappan <35987549+rohanp-msft@users.noreply.github.com> Co-authored-by: Scott Jones <sjones@microsoft.com> Co-authored-by: sachintaMSFT <80828309+sachintaMSFT@users.noreply.github.com> Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: eric langlois <email@ericlanglois.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> Co-authored-by: alexlamtest <68841560+alexlamtest@users.noreply.github.com> Co-authored-by: Paul Purifoy <33183370+pmpurifoy@users.noreply.github.com>

BootStrapTelemetry

f11ab64

sachintaMSFT requested a review from DrusTheAxe March 25, 2022 22:38

ghost added the needs-triage label Mar 25, 2022

sachintaMSFT added feature area-DynamicDependencies and removed needs-triage labels Mar 25, 2022

sachintaMSFT self-assigned this Mar 25, 2022

DrusTheAxe reviewed Mar 26, 2022

View reviewed changes

dev/WindowsAppRuntime_BootstrapDLL/WindowsAppRuntime_BootstrapDLL.vcxproj.filters Outdated Show resolved Hide resolved

DrusTheAxe reviewed Mar 26, 2022

View reviewed changes

sachintaMSFT changed the title ~~BootStrapTelemetry~~ MddBootstrap Telemetry & TraceLogging Mar 28, 2022

MddBootstrap telemetry

a4addb1

Merge from upstream/amin

34d79ea

sachintaMSFT requested review from jefgen and cwruss March 29, 2022 17:14

MddBootStrap API telemetry

e4617ab

DrusTheAxe requested changes Apr 8, 2022

View reviewed changes

DrusTheAxe reviewed Apr 14, 2022

View reviewed changes

dev/WindowsAppRuntime_BootstrapDLL/MddBootstrap.cpp Outdated Show resolved Hide resolved

DrusTheAxe reviewed Apr 14, 2022

View reviewed changes

dev/WindowsAppRuntime_BootstrapDLL/MddBootstrap.cpp Outdated Show resolved Hide resolved

Switch to using ThreadLoggingCallback instead of Process wide callback

81f8804

sachintaMSFT force-pushed the user/sachinta/BootStrap_Telemetry branch from dcc2f3a to 81f8804 Compare April 15, 2022 03:07

sachintaMSFT requested a review from DrusTheAxe April 15, 2022 03:07

DrusTheAxe requested changes Apr 15, 2022

View reviewed changes

sachintaMSFT force-pushed the user/sachinta/BootStrap_Telemetry branch 6 times, most recently from f8bfa45 to 33438fb Compare April 15, 2022 09:58

sachintaMSFT requested a review from DrusTheAxe April 15, 2022 09:59

sachintaMSFT force-pushed the user/sachinta/BootStrap_Telemetry branch from 33438fb to c1cf06b Compare April 18, 2022 13:38

Merge with upstream

1b59ed6

sachintaMSFT force-pushed the user/sachinta/BootStrap_Telemetry branch from c1cf06b to 1b59ed6 Compare April 18, 2022 14:56

DrusTheAxe approved these changes Apr 18, 2022

View reviewed changes

raghavthind2005 approved these changes Apr 27, 2022

View reviewed changes

Add safegaurds to call initialize and shutdown activity's StopWithRes…

32b43a5

…ult only when the activity is running.

sachintaMSFT merged commit 87298dd into main Apr 27, 2022

sachintaMSFT deleted the user/sachinta/BootStrap_Telemetry branch April 27, 2022 17:12

DefaultRyan reviewed Apr 29, 2022

View reviewed changes

fredemmott mentioned this pull request Jun 7, 2022

v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592

Closed

bpulliam added feature proposal and removed feature labels May 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MddBootstrap Telemetry & TraceLogging #2321

MddBootstrap Telemetry & TraceLogging #2321

sachintaMSFT commented Mar 25, 2022 •

edited

Loading

sachintaMSFT commented Mar 25, 2022

azure-pipelines bot commented Mar 25, 2022

riverar commented Mar 25, 2022

sachintaMSFT commented Mar 26, 2022

DrusTheAxe left a comment

sachintaMSFT commented Mar 26, 2022

sachintaMSFT commented Mar 29, 2022

azure-pipelines bot commented Mar 29, 2022

sachintaMSFT commented Mar 29, 2022

azure-pipelines bot commented Mar 29, 2022

sachintaMSFT commented Apr 15, 2022

azure-pipelines bot commented Apr 15, 2022

DrusTheAxe Apr 15, 2022

sachintaMSFT Apr 15, 2022

DrusTheAxe Apr 18, 2022

sachintaMSFT commented Apr 15, 2022

azure-pipelines bot commented Apr 15, 2022

sachintaMSFT commented Apr 18, 2022

azure-pipelines bot commented Apr 18, 2022

sachintaMSFT commented Apr 27, 2022

azure-pipelines bot commented Apr 27, 2022

DefaultRyan Apr 29, 2022

MddBootstrap Telemetry & TraceLogging #2321

MddBootstrap Telemetry & TraceLogging #2321

Conversation

sachintaMSFT commented Mar 25, 2022 • edited Loading

sachintaMSFT commented Mar 25, 2022

azure-pipelines bot commented Mar 25, 2022

riverar commented Mar 25, 2022

sachintaMSFT commented Mar 26, 2022

DrusTheAxe left a comment

Choose a reason for hiding this comment

sachintaMSFT commented Mar 26, 2022

sachintaMSFT commented Mar 29, 2022

azure-pipelines bot commented Mar 29, 2022

sachintaMSFT commented Mar 29, 2022

azure-pipelines bot commented Mar 29, 2022

sachintaMSFT commented Apr 15, 2022

azure-pipelines bot commented Apr 15, 2022

DrusTheAxe Apr 15, 2022

Choose a reason for hiding this comment

sachintaMSFT Apr 15, 2022

Choose a reason for hiding this comment

DrusTheAxe Apr 18, 2022

Choose a reason for hiding this comment

sachintaMSFT commented Apr 15, 2022

azure-pipelines bot commented Apr 15, 2022

sachintaMSFT commented Apr 18, 2022

azure-pipelines bot commented Apr 18, 2022

sachintaMSFT commented Apr 27, 2022

azure-pipelines bot commented Apr 27, 2022

DefaultRyan Apr 29, 2022

Choose a reason for hiding this comment

sachintaMSFT commented Mar 25, 2022 •

edited

Loading