-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trim Resource Id prefix from WINDOWSAPPRUNTIME_ to MSIX_ #2442
Merged
sachintaMSFT
merged 1 commit into
main
from
user/sachinta/TrimResourceIdToMeetLengthConstraint
Apr 26, 2022
Merged
Trim Resource Id prefix from WINDOWSAPPRUNTIME_ to MSIX_ #2442
sachintaMSFT
merged 1 commit into
main
from
user/sachinta/TrimResourceIdToMeetLengthConstraint
Apr 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
42ff4f6
to
9328e51
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
DrusTheAxe
approved these changes
Apr 26, 2022
kythant
added a commit
that referenced
this pull request
May 11, 2022
* Rename CsWinRT Dependency Variable for Windows SDK * update Version.Details.xml * Under a .NET SDK version check, bring back our (broken) default file inclusion solution for RESW and image files (applies to non-single project MSIX apps only). (#2424) * Under a .NET SDK version check, continue to use our (broken) default file inclusion solution for RESW and image files (applies to non-single project MSIX apps only). * Fixes: use the right version number and use the right property for the version number! Tested. * add end dev library adoption section, link to community call (#2428) * Replace WAR_ prefix with WINDOWSAPPRUNTIME_ prefix (#2430) Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * Fix IsSelfContained() to lookup framework packagefamilyname at runtime (#2411) * Added Microsoft::WindowsAppRuntime::VersionInfo::RuntimeInformation as a (partial) runtime-equivalent WindowsAppSDK-VersionInfo.h to workaround the chicken-egg problem where we need to know the versioninfo now but it's nto defined until higher in the build tree (the Aggregator pipeline at the top) * Replaced WindowsAppRuntime_SelfContainedTestInitialize with WindowsAppRuntime_VersionInfo_TestInitialize as we moved the functionality down a level * Removed dead code * Update docs for IsSelfContained * Update test to match SelfContained/VersionInfo::TestInitialize change * Add missing #include * Fix compiler warnings (#2420) * Update WinRT contracts per specs\WinRT\WinRTAPIContracts.md (some contract names didn't match or were absent) * Fixed warnings * Use correct type to avoid warnings on some platform (#2436) Co-authored-by: Eric Langlois <erlangl@microsoft.com> * Trim Resource Id prefix from WINDOWSAPPRUNTIME_ to MSIX_ (#2442) Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * MddBootstrap Telemetry & TraceLogging (#2321) * MddBootStrap API telemetry * Use ThreadLoggingCallback instead of Process wide callback for wil result logging callback * Add safegaurds to call initialize and shutdown activity's StopWithResult only when the activity is running. Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * Update WindowsAppSDK-RunHelixTests-Job.yml (#2455) Appended windows.11.amd64.client.open.reunion to helixTargetQueuesOpen and Windows.11.Amd64.client.Reunion to helixTargetQueuesClosed. * UndockedRegFreeWinRT auto-initialization (#2452) * Remove dead code * Add URWF auto-initializer * New URFW files * Connect the dots for URFW auto-initialization support * Added missing file. Fixed compiler warnings * Simplified the C# auto-initializer. Added a comment explaining why it works the way it does * Updated C# auto-initializers to shortcircuit any work if loaded for reflecction (vs execution) * Added missing using * Fix returning a reference to a local variable in GetActivityFlags(); returns a const enum so no reason it can't be by-value and the obvious correctness reason it can't be by-ref * Added build macro WindowsAppSDKCleanIntermediateFiles=<boolean> to scrub intermediate outputs as we build. Defaults to 'true' for build pipeline else undefined and thus not acted on (e.g. dev inner-loop) * Fix prototype for GetIntegrityFlags * Move WindowsAppSDKCleanIntermediateFiles to be a parameter defined by the pipeline, for better inner-loop (for those who want to use the option) * Deploy Main and Singleton in BreakAway process when Deployment API is called from MediumILHigherIL Non-Microsoft publisher package (#2454) Create DeploymentAgent.exe and run it in a breakaway process from Deployment API when the caller is packaged process and has MediumIL/HigherIL integrity level. Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * Log Installer events to disk (#2460) * Log Installer events to disk (Application.evtx or Eventvwr.exe -> Windows Logs -> Application) in "WindowsAppRuntime Installer" source. Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * Change Singleton package Name to Microsoft.WinAppRuntime.Singleton[-shorttag] * Yet Moar CorpII * Replace WARmain with WARsingleton to point to singleton package * Update Deployment ACIDs in Framework package manifest (#2472) Update Deployment ACIDs in Framework package manifest Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * Fix UndockedRegFreeWinRT auto-initializer issues (#2476) * Fix bad filename * No precompiledheaders when compiling the auto-initializer * Copy DeploymentAgent executable to TestFwkPkg (#2467) * Copy DeploymentAgent executable to TestFwkPkg * Make DeploymentAgent a dependency to build Microsoft.Windows.Framework Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * Add PushNotificationsLongRunningTask.ProxyStub pdb to symbols dir (#2361) Co-authored-by: Eric Langlois <erlangl@microsoft.com> * Some refinements on the UndockedRegFreeWinRT self-contained and auto-initialization support (#2493) Co-authored-by: Joshua Larkin <70237359+j0shuams@users.noreply.github.com> Co-authored-by: Rohan Palaniappan <35987549+rohanp-msft@users.noreply.github.com> Co-authored-by: Scott Jones <sjones@microsoft.com> Co-authored-by: sachintaMSFT <80828309+sachintaMSFT@users.noreply.github.com> Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: eric langlois <email@ericlanglois.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> Co-authored-by: alexlamtest <68841560+alexlamtest@users.noreply.github.com> Co-authored-by: Paul Purifoy <33183370+pmpurifoy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resource Id has a length constraint of 31 characters. The resource compiler is auto truncating the resource Ids to that length of 31 characters. Hence, replacing WINDOWSAPPRUNTIME_ prefix with MSIX_ prefix to be within length constraint limits.
Longest resource Id is with this fix is MSIX_SINGLETON_LICENSE_RCENTRY that is of length 30 characters.