-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FI Main into Develop #2497
Merged
Merged
FI Main into Develop #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inclusion solution for RESW and image files (applies to non-single project MSIX apps only). (#2424) * Under a .NET SDK version check, continue to use our (broken) default file inclusion solution for RESW and image files (applies to non-single project MSIX apps only). * Fixes: use the right version number and use the right property for the version number! Tested.
Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com>
#2411) * Added Microsoft::WindowsAppRuntime::VersionInfo::RuntimeInformation as a (partial) runtime-equivalent WindowsAppSDK-VersionInfo.h to workaround the chicken-egg problem where we need to know the versioninfo now but it's nto defined until higher in the build tree (the Aggregator pipeline at the top) * Replaced WindowsAppRuntime_SelfContainedTestInitialize with WindowsAppRuntime_VersionInfo_TestInitialize as we moved the functionality down a level * Removed dead code * Update docs for IsSelfContained * Update test to match SelfContained/VersionInfo::TestInitialize change * Add missing #include
* Update WinRT contracts per specs\WinRT\WinRTAPIContracts.md (some contract names didn't match or were absent) * Fixed warnings
Co-authored-by: Eric Langlois <erlangl@microsoft.com>
Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com>
* MddBootStrap API telemetry * Use ThreadLoggingCallback instead of Process wide callback for wil result logging callback * Add safegaurds to call initialize and shutdown activity's StopWithResult only when the activity is running. Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com>
Rename CsWinRT Dependency Variable for Windows SDK
Appended windows.11.amd64.client.open.reunion to helixTargetQueuesOpen and Windows.11.Amd64.client.Reunion to helixTargetQueuesClosed.
* Remove dead code * Add URWF auto-initializer * New URFW files * Connect the dots for URFW auto-initialization support * Added missing file. Fixed compiler warnings * Simplified the C# auto-initializer. Added a comment explaining why it works the way it does * Updated C# auto-initializers to shortcircuit any work if loaded for reflecction (vs execution) * Added missing using * Fix returning a reference to a local variable in GetActivityFlags(); returns a const enum so no reason it can't be by-value and the obvious correctness reason it can't be by-ref * Added build macro WindowsAppSDKCleanIntermediateFiles=<boolean> to scrub intermediate outputs as we build. Defaults to 'true' for build pipeline else undefined and thus not acted on (e.g. dev inner-loop) * Fix prototype for GetIntegrityFlags * Move WindowsAppSDKCleanIntermediateFiles to be a parameter defined by the pipeline, for better inner-loop (for those who want to use the option)
… called from MediumILHigherIL Non-Microsoft publisher package (#2454) Create DeploymentAgent.exe and run it in a breakaway process from Deployment API when the caller is packaged process and has MediumIL/HigherIL integrity level. Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com>
* Log Installer events to disk (Application.evtx or Eventvwr.exe -> Windows Logs -> Application) in "WindowsAppRuntime Installer" source. Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com>
…horttag] (#2465) Change Singleton package Name to Microsoft.WinAppRuntime.Singleton[-shorttag]
Update Deployment ACIDs in Framework package manifest Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com>
* Fix bad filename * No precompiledheaders when compiling the auto-initializer
* Copy DeploymentAgent executable to TestFwkPkg * Make DeploymentAgent a dependency to build Microsoft.Windows.Framework Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com>
…initialization support (#2493)
/azp run |
ghost
added
the
needs-triage
label
May 11, 2022
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
loneursid
approved these changes
May 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.