Deploy Storybook to gh-pages from Travis #54
Conversation
|
@unindented, |
config/travis/build.sh
Outdated
| # if [ "$TRAVIS_PULL_REQUEST" != "false" ] ; then | ||
| # echo "This commit was made in a pull request. No build for you!" | ||
| # exit 0 | ||
| # fi |
There was a problem hiding this comment.
This will be uncommented. I'm just seeing whether everything works fine in this PR.
unindented
force-pushed
the
dalvarez-gh-pages
branch
7 times, most recently
from
995ea2f
to
2b32056
Compare
|
This is great work!!! I have been so slowed down by replacing the bundles and docs, every time. Thank you for doing this. |
We were using a mixture of && and npm-run-all. It's clearer if we use one for everything.
unindented
force-pushed
the
dalvarez-gh-pages
branch
from
2b32056
to
15f7f6a
Compare
config/travis/build.sh
Outdated
| set -o nounset | ||
|
|
||
| if [ "$TRAVIS_BRANCH" != "master" ] ; then | ||
| echo "This commit was made against $TRAVIS_BRANCH and not master. No build for you!" |
There was a problem hiding this comment.
Instead of No build for you!, should we give more build context and say something like Not generating updated docs on gh-pages branch.? same for line 13
| @@ -91,13 +91,13 @@ | |||
| "watch:css:components": "postcss \"src/components/**/*.css\" --dir \"dist/components\" --base \"src/components\" --watch", | |||
| "watch:ts:components": "tsc --project . --watch", | |||
| "watch": "run-p watch:**", | |||
| "start:dev": "yarn build && run-p watch storybook:start", | |||
| "start:dev": "npm-run-all build --parallel watch storybook:start", | |||
There was a problem hiding this comment.
is this functionally the same, just with a different syntax?
There was a problem hiding this comment.
Yup. I didn't want to do the same thing in two different ways. I was also unsure how && behaves on Windows.
unindented
force-pushed
the
dalvarez-gh-pages
branch
from
15f7f6a
to
4b466e5
Compare
package.json
Outdated
| "clean:build": "rimraf build/*", | ||
| "clean:dist": "rimraf dist/*", | ||
| "clean": "run-p clean:*", |
There was a problem hiding this comment.
since storybook is now in the build dir this could be
"clean": "run-p clean:build clean:dist
unindented
force-pushed
the
dalvarez-gh-pages
branch
from
d148e83
to
c2401fe
Compare
unindented
force-pushed
the
dalvarez-gh-pages
branch
from
c2401fe
to
50bf89f
Compare
Instead of committing the
docsfolder as part of every PR, I propose building it when Travis runs after a merge into master, and committing togh-pagesfrom Travis itself using a deploy key.Fixes #6
Fixes #53