Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter suggestions #292

Merged
merged 4 commits into from
Dec 15, 2016
Merged

Fix linter suggestions #292

merged 4 commits into from
Dec 15, 2016

Conversation

guperrot
Copy link
Member

No description provided.

@msftclas
Copy link

Hi @guperrot, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Guillaume Perrot). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@codecov-io
Copy link

codecov-io commented Dec 15, 2016

Current coverage is 100% (diff: 100%)

Merging #292 into develop will not change coverage

@@           develop   #292   diff @@
=====================================
  Files           59     59          
  Lines         2622   2622          
  Methods          0      0          
  Messages         0      0          
  Branches       482    482          
=====================================
  Hits          2622   2622          
  Misses           0      0          
  Partials         0      0          

Powered by Codecov. Last update 3e26bcb...c4c2876

@jaeklim
Copy link
Contributor

jaeklim commented Dec 15, 2016

Looks good to me but it would be good to take projectDependency stuffs out of main. Default should be jcenterDependency which has less features than the other.

@guperrot guperrot merged commit a312cfe into develop Dec 15, 2016
@guperrot guperrot deleted the fix/lint branch December 15, 2016 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants