Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inter-GPU connection setup #115

Merged
merged 13 commits into from
Sep 9, 2023
Merged

Fix inter-GPU connection setup #115

merged 13 commits into from
Sep 9, 2023

Conversation

chhwang
Copy link
Contributor

@chhwang chhwang commented Sep 6, 2023

  • Now GpuMem does not use IpcMem internally
  • Fix GpuCommSw::configure()
  • Add a unit test test_sched_many_comm_ops
  • Minor IPC chanages

@chhwang chhwang marked this pull request as ready for review September 8, 2023 13:49
@chhwang chhwang changed the title Fix GpuCommSw::configure Fix inter-GPU connection setup Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #115 (8e44193) into main (335da67) will decrease coverage by 0.24%.
The diff coverage is 83.67%.

❗ Current head 8e44193 differs from pull request most recent head 5b71409. Consider uploading reports for the commit 5b71409 to get more accurate results

@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   73.63%   73.39%   -0.24%     
==========================================
  Files         112      112              
  Lines        9098     9039      -59     
==========================================
- Hits         6699     6634      -65     
- Misses       2399     2405       +6     
Files Changed Coverage Δ
ark/gpu/gpu_mgr_test.cc 100.00% <ø> (ø)
ark/ipc/ipc_mem.cc 63.86% <64.28%> (-11.65%) ⬇️
ark/gpu/gpu_mgr.cc 66.91% <71.42%> (-0.62%) ⬇️
ark/gpu/gpu_comm_sw.cc 77.27% <85.54%> (-1.78%) ⬇️
ark/gpu/gpu_mem.cc 82.75% <86.15%> (+0.30%) ⬆️
ark/gpu/gpu_buf.h 100.00% <100.00%> (ø)
ark/gpu/gpu_kernel.cc 82.92% <100.00%> (ø)
ark/gpu/gpu_mem.h 100.00% <100.00%> (ø)
ark/gpu/gpu_mem_test.cc 100.00% <100.00%> (ø)
ark/ipc/ipc_mem.h 100.00% <100.00%> (ø)
... and 4 more

... and 1 file with indirect coverage changes

📢 Have feedback on the report? Share it here.

@chhwang chhwang merged commit faa69f5 into main Sep 9, 2023
9 checks passed
@chhwang chhwang deleted the chhwang/fix-configure branch September 9, 2023 02:20
Binyang2014 pushed a commit that referenced this pull request Oct 10, 2023
* Now `GpuMem` does not use `IpcMem` internally
* Fix `GpuCommSw::configure()`
* Add a unit test `test_sched_many_comm_ops`
* Minor IPC chanages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant