Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix batched matmul & add a unit test #117

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Conversation

chhwang
Copy link
Contributor

@chhwang chhwang commented Sep 13, 2023

No description provided.

@chhwang chhwang marked this pull request as ready for review September 13, 2023 06:35
@chhwang chhwang mentioned this pull request Sep 13, 2023
14 tasks
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #117 (042f7a8) into main (faa69f5) will decrease coverage by 0.01%.
The diff coverage is 75.92%.

❗ Current head 042f7a8 differs from pull request most recent head e8ddc44. Consider uploading reports for the commit e8ddc44 to get more accurate results

@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
- Coverage   73.39%   73.39%   -0.01%     
==========================================
  Files         112      112              
  Lines        9039     9072      +33     
==========================================
+ Hits         6634     6658      +24     
- Misses       2405     2414       +9     
Files Changed Coverage Δ
ark/ops/ops_matmul_test.cu 86.25% <75.92%> (-2.12%) ⬇️

... and 1 file with indirect coverage changes

@chhwang chhwang merged commit 3e540b0 into main Sep 13, 2023
9 checks passed
@chhwang chhwang deleted the chhwang/fix-batched-mm branch September 13, 2023 08:21
Binyang2014 pushed a commit that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant