Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the embedding layer #122

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Add the embedding layer #122

merged 1 commit into from
Sep 18, 2023

Conversation

chhwang
Copy link
Contributor

@chhwang chhwang commented Sep 18, 2023

No description provided.

@chhwang chhwang marked this pull request as ready for review September 18, 2023 09:58
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #122 (d3f3f48) into main (e4f47dd) will increase coverage by 0.29%.
Report is 2 commits behind head on main.
The diff coverage is 89.55%.

❗ Current head d3f3f48 differs from pull request most recent head 7aa400f. Consider uploading reports for the commit 7aa400f to get more accurate results

@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
+ Coverage   72.61%   72.90%   +0.29%     
==========================================
  Files          80       81       +1     
  Lines        6380     6441      +61     
==========================================
+ Hits         4633     4696      +63     
+ Misses       1747     1745       -2     
Files Changed Coverage Δ
ark/include/ark.h 100.00% <ø> (ø)
ark/ops/ops_common.h 100.00% <ø> (ø)
ark/tensor.cc 62.40% <0.00%> (-0.99%) ⬇️
ark/ops/ops_common.cc 63.40% <66.66%> (+0.02%) ⬆️
ark/ops/ops_test_common.cc 80.71% <85.00%> (+3.89%) ⬆️
ark/ops/ops_embedding.cc 93.33% <93.33%> (ø)
ark/executor.cc 93.22% <93.61%> (-0.40%) ⬇️
ark/gpu/gpu_compile.cc 80.95% <100.00%> (+0.62%) ⬆️
ark/gpu/gpu_mgr.cc 76.95% <100.00%> (+0.08%) ⬆️
ark/ops/ops_layernorm.cc 84.21% <100.00%> (ø)
... and 5 more

... and 1 file with indirect coverage changes

@chhwang chhwang merged commit 7181c95 into main Sep 18, 2023
9 checks passed
@chhwang chhwang deleted the chhwang/embedding branch September 18, 2023 10:32
@chhwang chhwang mentioned this pull request Sep 4, 2023
3 tasks
Binyang2014 pushed a commit that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant