Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add msll support #152

Merged
merged 181 commits into from
Oct 27, 2023
Merged

Add msll support #152

merged 181 commits into from
Oct 27, 2023

Conversation

Binyang2014
Copy link
Contributor

No description provided.

chhwang and others added 30 commits July 20, 2023 18:22
@chhwang
Initial commit
a4c9c3d
@microsoftopensource
CODE_OF_CONDUCT.md committed
e6a942d
@microsoftopensource
LICENSE updated to template
b5c9119
@microsoftopensource
README.md updated to template
40ea06d
@microsoftopensource
SECURITY.md committed
6beedcb
@microsoftopensource
SUPPORT.md committed
edf84a9
@Binyang2014
merge main
8f64a8b
@chhwang
Merge pull request #1 from microsoft/init
5120df5 
Init mscclpp-ark repo
@chhwang
Update codeql.yml (#2)
b37e75d
@chhwang
Revise OP declaration & retrieval (#46)
82ad47b
@chhwang
Fix a GpuMem bug (#49)
80d921f
@chhwang
Fix a shared memory scheduling bug (#50)
bd78c44
@chhwang
Add citation (#51)
9a107a7
@chhwang
Revisions around schedulers (#52)
581a608
@chhwang
Fix scheduler bugs (#54)
6ac8977
@wusar @chhwang
Improve Python interfaces (#48)
03a5b31 
Improve Python interfaces
@chhwang
Update schedulers (#56)
abb036c 
* Update shared memory scheduling
* Computation-communication overlapping for allreduce
@wusar @chhwang
Fix a simple usage bug (#55)
ab0d1a2 
Fix a usgae bug in the unittest code

Co-authored-by: Changho Hwang <changhohwang@microsoft.com>
@chhwang
Deprecate old custom cutlass implementation (#57)
33f4718
@chhwang
Minor updates (#59)
c2b64f6 
* Changed identity op interface
* Support non-tiled operators
@chhwang
v0.1.0 (#60)
9c44ab9
@chhwang
Early exit if gpumem is not loaded (#63)
e6f6a4f
@wusar @chhwang
Fix a bug in the python wrapper (#65)
4ec467d
@wusar @chhwang
Fix a simple bug in the code generator (#66)
f20aa33
@chhwang
Update install.md (#69)
a7299f4
@chhwang
Update requirements.txt (#70)
b673b43
@chhwang
Support float type for matmul and reduce_e (#67)
abbae48
@wusar @chhwang
fix an error in the quickstart.md (#71)
b41a0a7 
Fix a simple error in the quick_start.md
@chhwang
Integration working. Need cleanup
7161e99
@chhwang
Some fixes
390fdfb
@Binyang2014 Binyang2014 changed the title Binyli/merge Add msll support Oct 25, 2023
@Binyang2014 Binyang2014 marked this pull request as ready for review October 25, 2023 09:20
chhwang
chhwang requested changes Oct 25, 2023
View reviewed changes
ark/include/ark.h Outdated Show resolved Hide resolved
ark/ops/ops_packet_msll.cc Outdated Show resolved Hide resolved
ark/ops/ops_packet_msll.cc Outdated Show resolved Hide resolved
ark/ops/ops_sendrecv_msll.cc Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

Merging #152 (c4fd10e) into main (6e9611a) will decrease coverage by 6.51%.
The diff coverage is 7.61%.

❗ Current head c4fd10e differs from pull request most recent head ff929e7. Consider uploading reports for the commit ff929e7 to get more accurate results

@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
- Coverage   78.19%   71.69%   -6.51%     
==========================================
  Files          84       89       +5     
  Lines        6031     6634     +603     
==========================================
+ Hits         4716     4756      +40     
- Misses       1315     1878     +563
Files Coverage Δ
ark/gpu/gpu_kernel.cc 83.49% <100.00%> (+0.16%) ⬆️
ark/gpu/gpu_mgr.cc 78.19% <100.00%> (+0.62%) ⬆️
ark/include/ark.h 100.00% <ø> (ø)
ark/model.h 100.00% <ø> (ø)
ark/ops/ops_common.h 100.00% <ø> (ø)
ark/ops/ops_test_common.cc 88.65% <100.00%> (ø)
ark/sched/sched_opseq.h 66.66% <ø> (ø)
ark/gpu/gpu_compile.cc 88.37% <57.14%> (-1.76%) ⬇️
ark/ops/ops_sendrecv.cc 88.57% <50.00%> (+1.61%) ⬆️
ark/env.cc 72.46% <64.28%> (-2.09%) ⬇️
... and 11 more

@chhwang chhwang mentioned this pull request Oct 25, 2023
Closed
chhwang
chhwang approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@chhwang chhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will revisit for perf fix

@chhwang chhwang merged commit 4ea90ec into microsoft:main Oct 27, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chhwang chhwang chhwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Binyang2014 @chhwang @microsoftopensource @wusar