Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROCm support #162

Merged
merged 109 commits into from
Nov 6, 2023
Merged

ROCm support #162

merged 109 commits into from
Nov 6, 2023

Conversation

chhwang
Copy link
Contributor

@chhwang chhwang commented Nov 4, 2023

Add supports for AMD's CDNA2 architecture. Multi-GPU execution is not yet supported for AMD GPUs.

@chhwang chhwang marked this pull request as ready for review November 5, 2023 09:42
Base automatically changed from chhwang/kernels to main November 5, 2023 11:13
Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #162 (f9550db) into main (d877ea2) will increase coverage by 0.24%.
The diff coverage is 82.94%.

❗ Current head f9550db differs from pull request most recent head 875304d. Consider uploading reports for the commit 875304d to get more accurate results

@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
+ Coverage   70.56%   70.81%   +0.24%     
==========================================
  Files          92       93       +1     
  Lines        6955     7075     +120     
==========================================
+ Hits         4908     5010     +102     
- Misses       2047     2065      +18     
Files Coverage Δ
ark/gpu/gpu_kernel.h 100.00% <ø> (ø)
ark/gpu/gpu_mem.h 100.00% <ø> (ø)
ark/gpu/gpu_mgr.h 100.00% <ø> (ø)
ark/ops/ops_add.cc 90.47% <ø> (ø)
ark/ops/ops_cast.cc 76.92% <ø> (ø)
ark/ops/ops_common.h 100.00% <ø> (ø)
ark/ops/ops_copy.cc 92.30% <ø> (ø)
ark/ops/ops_embedding.cc 94.73% <ø> (ø)
ark/ops/ops_im2col.cc 81.53% <ø> (ø)
ark/ops/ops_layernorm.cc 87.87% <ø> (ø)
... and 19 more

@chhwang chhwang marked this pull request as draft November 6, 2023 04:53
@chhwang chhwang marked this pull request as ready for review November 6, 2023 07:36
@chhwang chhwang merged commit 2e0c7d4 into main Nov 6, 2023
10 checks passed
@chhwang chhwang deleted the chhwang/rocm2 branch November 6, 2023 10:07
chhwang added a commit that referenced this pull request Nov 6, 2023
Revert unstable updates.
chhwang added a commit that referenced this pull request Nov 6, 2023
Revert unstable updates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant