-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement docker based command line code executor #1856
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1856 +/- ##
===========================================
+ Coverage 36.10% 47.65% +11.54%
===========================================
Files 63 64 +1
Lines 6658 6784 +126
Branches 1470 1618 +148
===========================================
+ Hits 2404 3233 +829
+ Misses 4056 3288 -768
- Partials 198 263 +65
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some docs on constructor is needed. Some note for the next PR.
@ekzhu, should be ready to go |
* implement docker based command line code executor * undo import * test skips * format * fix type issue * skip docker tests * fix paths * add docs * Update __init__.py * class name * precommit * undo twoagent change * use relative to directly * Update, fixes, etc. * update doc * Update docstring --------- Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
Why are these changes needed?
This PR implements Docker based command line code execution in the new code executor framework.
This docker executor also solves the issue where many images are created and polluting the user's Docker installation. It works by running commands in a running container, rather than the old way where it would run each command in a new layer and commit it.
Related issue number
Checks