Implement docker based command line code executor #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1856 +/- ##
===========================================
+ Coverage 36.10% 47.65% +11.54%
===========================================
Files 63 64 +1
Lines 6658 6784 +126
Branches 1470 1618 +148
===========================================
+ Hits 2404 3233 +829
+ Misses 4056 3288 -768
- Partials 198 263 +65
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ekzhu
reviewed
Mar 6, 2024
ekzhu
approved these changes
Mar 7, 2024
ekzhu
requested changes
Mar 7, 2024
|
@ekzhu, should be ready to go |
ekzhu
approved these changes
Mar 7, 2024
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
* implement docker based command line code executor * undo import * test skips * format * fix type issue * skip docker tests * fix paths * add docs * Update __init__.py * class name * precommit * undo twoagent change * use relative to directly * Update, fixes, etc. * update doc * Update docstring --------- Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR implements Docker based command line code execution in the new code executor framework.
This docker executor also solves the issue where many images are created and polluting the user's Docker installation. It works by running commands in a running container, rather than the old way where it would run each command in a new layer and commit it.
Related issue number
Checks