Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin databind version to fix pydoc-markdown failure in CI #2091

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

ekzhu
Copy link
Collaborator

@ekzhu ekzhu commented Mar 20, 2024

Why are these changes needed?

The latest 4.5.0 release of databind packages causes issue with pydoc-markdown. Force install the 4.4.2 version in CI.

Related issue number

Checks

@ekzhu ekzhu added the dev label Mar 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.88%. Comparing base (38b64b6) to head (a50337f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2091   +/-   ##
=======================================
  Coverage   36.88%   36.88%           
=======================================
  Files          68       68           
  Lines        7062     7062           
  Branches     1540     1540           
=======================================
  Hits         2605     2605           
  Misses       4228     4228           
  Partials      229      229           
Flag Coverage Δ
unittests 36.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Depending on how long it takes to find an alternative, we may also need to update other places where pydoc-markdown is used.

@sonichi sonichi added this pull request to the merge queue Mar 20, 2024
Merged via the queue into main with commit 6cab643 Mar 20, 2024
23 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants