-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add bind_dir arg to DockerCommandLineExecutor + docs update #2309
Conversation
@microsoft-github-policy-service agree |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2309 +/- ##
===========================================
+ Coverage 38.14% 50.05% +11.91%
===========================================
Files 78 78
Lines 7865 7873 +8
Branches 1683 1824 +141
===========================================
+ Hits 3000 3941 +941
+ Misses 4615 3600 -1015
- Partials 250 332 +82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…crosoft#2309) * add bind_dir arg and update docs * lint
Why are these changes needed?
When the user wants deploy an application to a scenario in which the main app runs in a docker container that executes code using the
DockerCommandLineExecutor
, only binding thedocker.sock
is not enough. If the spawned container needs file access from the host, the check that the constructor method of the DockerCommandLineExecutor cli does to work_dir prevents this from happening. Adding a new bind_dir argument solves this without breaking old code and allows for such behavior to be supported.Related issue number
Checks