-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support openai 'sk-proj-' apikey format #2426
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | Generic High Entropy Secret | ef77502 | test/oai/test_utils.py | View secret | |
- | Generic High Entropy Secret | ef77502 | test/oai/test_utils.py | View secret | |
- | Generic High Entropy Secret | ef77502 | test/oai/test_utils.py | View secret | |
- | Generic High Entropy Secret | ef77502 | test/oai/test_utils.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
@microsoft-github-policy-service agree |
@nerfZael could you take a look at this PR? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2426 +/- ##
==========================================
+ Coverage 38.14% 39.60% +1.46%
==========================================
Files 78 82 +4
Lines 7865 8355 +490
Branches 1683 1922 +239
==========================================
+ Hits 3000 3309 +309
- Misses 4615 4762 +147
- Partials 250 284 +34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Why are these changes needed?
I recently created a new oai api key and found that it has 'sk-proj-' as the prefix, and the current code base can only match the 'sk-' prefix.
autogen/autogen/oai/openai_utils.py
Line 93 in d307818
Related issue number
Checks