-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update graph_utils.py #2601
Update graph_utils.py #2601
Conversation
Adds save_speaker_transitions_dict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for coming back with a PR.
Given the 90+% overlap with visualize_speaker_transitions_dict
, I'd suggest adding a export_path:str which defaults to None into visualize_speaker_transitions_dict
. In there, run plt.savefig(path) if export_path
is not None
Adds export_path:str which defaults to None into visualize_speaker_transitions_dict. In there, run plt.savefig(path) if export_path is not None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @moresearch. Looks good to me! :)
Hey @moresearch, a tip to run |
Adds export_path functionality to visualize_speaker_transitions_dict()
Thanks for the tip @joshkyh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, and non-llm tests are passing. Perhaps good to merge, @ekzhu?
* Update graph_utils.py Adds save_speaker_transitions_dict * Update graph_utils.py Adds export_path:str which defaults to None into visualize_speaker_transitions_dict. In there, run plt.savefig(path) if export_path is not None * Update graph_utils.py * Update graph_utils.py Adds export_path functionality to visualize_speaker_transitions_dict() --------- Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Adds export_path for visualize_speaker_transitions_dict
Why are these changes needed?
Related issue number
Checks