Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graph_utils.py #2601

Merged
merged 8 commits into from
May 10, 2024
Merged

Update graph_utils.py #2601

merged 8 commits into from
May 10, 2024

Conversation

moresearch
Copy link
Contributor

@moresearch moresearch commented May 5, 2024

Adds export_path for visualize_speaker_transitions_dict

Why are these changes needed?

Related issue number

Checks

Adds save_speaker_transitions_dict
@ekzhu ekzhu requested a review from joshkyh May 6, 2024 03:53
@ekzhu ekzhu added the group chat/teams group-chat-related issues label May 6, 2024
Copy link
Collaborator

@joshkyh joshkyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for coming back with a PR.

Given the 90+% overlap with visualize_speaker_transitions_dict, I'd suggest adding a export_path:str which defaults to None into visualize_speaker_transitions_dict. In there, run plt.savefig(path) if export_path is not None

moresearch and others added 3 commits May 6, 2024 13:03
Adds export_path:str which defaults to None into visualize_speaker_transitions_dict. In there, run plt.savefig(path) if export_path is not None
Copy link
Collaborator

@joshkyh joshkyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @moresearch. Looks good to me! :)

@joshkyh
Copy link
Collaborator

joshkyh commented May 7, 2024

Hey @moresearch, a tip to run pre-commit run --all-files on the root folder of the Autogen dev container to pass
Code formatting / pre-commit-check (pull_request) Failing after 41s

Adds export_path functionality to visualize_speaker_transitions_dict()
@moresearch
Copy link
Contributor Author

Thanks for the tip @joshkyh

@moresearch moresearch requested a review from joshkyh May 9, 2024 10:59
Copy link
Collaborator

@joshkyh joshkyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and non-llm tests are passing. Perhaps good to merge, @ekzhu?

@ekzhu ekzhu added this pull request to the merge queue May 10, 2024
Merged via the queue into microsoft:main with commit 6dd2b59 May 10, 2024
75 of 88 checks passed
@moresearch moresearch deleted the patch-1 branch May 11, 2024 23:33
jayralencar pushed a commit to jayralencar/autogen that referenced this pull request May 28, 2024
* Update graph_utils.py

Adds save_speaker_transitions_dict

* Update graph_utils.py

Adds export_path:str which defaults to None into visualize_speaker_transitions_dict. In there, run plt.savefig(path) if export_path is not None

* Update graph_utils.py

* Update graph_utils.py

Adds export_path functionality to visualize_speaker_transitions_dict()

---------

Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group chat/teams group-chat-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants