Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify-windows.ps1 script doesn't search for prerelease VisualStudio installs #173

Closed
stevekiene opened this issue Mar 22, 2019 · 3 comments
Assignees

Comments

@stevekiene
Copy link

$vsWhereOutput = (& $vswhere -format xml)

Might want to consider having the -prerelease flag to add searches for non-release versions of VS. Otherwise the script fails when a user only has prerelease versions installed.

@schultetwin1
Copy link
Contributor

Ah, good call. I'll add that

@schultetwin1
Copy link
Contributor

Whoops, referenced wrong PR.

@schultetwin1
Copy link
Contributor

@stevekiene this should now be fixed. We are also now validating builds under VS2019 so building using VS2019 should be build break free. We are also unit testing the bits from VS2019 but not testing them against actual hardware, so you have a slight chance of running into an issue there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants