Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to Node 16 #844

Merged
merged 22 commits into from
Jul 8, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,5 @@ Your pull request should:
* At least one test should fail in the absence of your non-test code changes. If your PR does not match this criteria, please specify why
* Tests should include reasonable permutations of the target fix/change
* Include baseline changes with your change
* All changed code must have 100% code coverage
* All changed code must have 100% code coverage

20 changes: 10 additions & 10 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ jobs:
command: install
workingDir: node

# use node 10
# use node 16.13.0
- task: NodeTool@0
displayName: (azure-pipelines-task-lib) use node 10.23.0
displayName: (azure-pipelines-task-lib) use node 16.13.0
inputs:
versionSpec: "10.23.0"
versionSpec: "16.13.0"

# build/test
- script: |
Expand Down Expand Up @@ -78,11 +78,11 @@ jobs:
command: install
workingDir: node

# use node 10
# use node 16.13.0
- task: NodeTool@0
displayName: (azure-pipelines-task-lib) use node 10.23.0
displayName: (azure-pipelines-task-lib) use node 16.13.0
inputs:
versionSpec: "10.23.0"
versionSpec: "16.13.0"

# build/test
AndreyIvanov42 marked this conversation as resolved.
Show resolved Hide resolved
- script: node make.js test
Expand All @@ -101,7 +101,7 @@ jobs:
npm publish || true # Ignore publish failures, usually will happen because package already exists
displayName: (azure-pipelines-task-lib) npm publish
workingDirectory: node
condition: and(succeeded(), in(variables['build.reason'], 'IndividualCI', 'BatchedCI', 'Manual'), in(variables['build.sourcebranchname'], 'master', 'releases/3.x'))
condition: and(succeeded(), in(variables['build.reason'], 'IndividualCI', 'BatchedCI', 'Manual'), in(variables['build.sourcebranchname'], 'master', 'releases/4.x'))
env:
NPM_TOKEN: $(npmPublishToken)

Expand All @@ -124,11 +124,11 @@ jobs:
command: install
workingDir: node

# use node 10
# use node 16.13.0
- task: NodeTool@0
displayName: (azure-pipelines-task-lib) use node 10.23.0
displayName: (azure-pipelines-task-lib) use node 16.13.0
inputs:
versionSpec: "10.23.0"
versionSpec: "16.13.0"

# build/test
- script: node make.js test
Expand Down
2 changes: 1 addition & 1 deletion node/buildutils.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ exports.getExternals = function () {
// and add node to the PATH
var nodeUrl = process.env['TASK_NODE_URL'] || 'https://nodejs.org/dist';
nodeUrl = nodeUrl.replace(/\/$/, ''); // ensure there is no trailing slash on the base URL
var nodeVersion = 'v10.23.0';
var nodeVersion = 'v16.13.0';
switch (platform) {
case 'darwin':
var nodeArchivePath = downloadArchive(nodeUrl + '/' + nodeVersion + '/node-' + nodeVersion + '-darwin-x64.tar.gz');
Expand Down
Loading