Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated archiver in Tasks/Common/webdeployment-common-v2 #16310

Conversation

sbalia
Copy link
Contributor

@sbalia sbalia commented May 11, 2022

Task name: Tasks/Common/webdeployment-common-v2; AzureSpringCloudV0

Description:
Archiver contained an outdated reference to lodash. I bumped archiver version to the latest.

Also bumped webdeployment-common-v2 in the AzureSpringCloudV0 task as it is related to each other.

Versions of lodash before 4.17.12 are vulnerable to Prototype Pollution. The function defaultsDeep allows a malicious user to modify the prototype of Object via {constructor: {prototype: {...}}} causing the addition or modification of an existing property that will exist on all objects.

Documentation changes required: N

Added unit tests: N

Attached related issue: Y
GHSA-jf85-cpcp-j695
#16406

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected - smoke tested with AzureSpringCloudV0 task.

@sbalia sbalia force-pushed the users/sbalia/fixed-lodash-in-webdeployment-common-v2 branch from 6a74d34 to c5d7e38 Compare May 19, 2022 09:57
@sbalia sbalia marked this pull request as draft May 19, 2022 12:45
@sbalia sbalia force-pushed the users/sbalia/fixed-lodash-in-webdeployment-common-v2 branch 3 times, most recently from 5695173 to 7987093 Compare May 24, 2022 13:25
@sbalia sbalia changed the title Updated lodash in Tasks/Common/webdeployment-common-v2 Updated archiver in Tasks/Common/webdeployment-common-v2 May 24, 2022
@sbalia sbalia marked this pull request as ready for review May 24, 2022 13:32
@sbalia sbalia force-pushed the users/sbalia/fixed-lodash-in-webdeployment-common-v2 branch from 3370131 to 503fb85 Compare May 24, 2022 13:42
@sbalia sbalia force-pushed the users/sbalia/fixed-lodash-in-webdeployment-common-v2 branch 3 times, most recently from 9df6551 to c4f9e59 Compare June 4, 2022 15:41
@sbalia
Copy link
Contributor Author

sbalia commented Jun 5, 2022

related PR: #16406. I think it should be done in one PR, otherwise, I don't understand how to merge one without another

@KonstantinTyukalov
Copy link
Contributor

@yevster could you check?

@sbalia sbalia force-pushed the users/sbalia/fixed-lodash-in-webdeployment-common-v2 branch from 14af2d9 to e01d94f Compare June 8, 2022 09:45
@sbalia sbalia merged commit edbe980 into microsoft:master Jun 8, 2022
@sbalia sbalia deleted the users/sbalia/fixed-lodash-in-webdeployment-common-v2 branch June 8, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants