Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed vulnerabilities in MSBuildV1 task and updated task-lib-version till 3.3.1 #16569

Conversation

SvetlanaMaliugina
Copy link
Contributor

@SvetlanaMaliugina SvetlanaMaliugina commented Jul 11, 2022

Task name: MSBuildV1
Description: Fixed vulnerabilities with shelljs in MSBuildV1 task. azure-pipelines-task-lib version was updated for Tasks/Common/MSBuildHelpers common package.
MSBuildV1, VSBuildV1, and XamarinAndroidV1 versions were bumped since these tasks depend on this common package.

Documentation changes required: N

Added unit tests: N

Attached related issue: [Governance alerts] MSBuildV1 task (shelljs) #3070

Checklist:

  • Task version was bumped
  • Checked that applied changes work as expected

Risks analysis checklist:

  • There are no risky dependency updates
  • Changes have been tested
  • Enough test coverage for changes and current test coverage for tasks doesn't look poor
  • We understand how tasks are working, how changes affect tasks behavior
  • There are no breaking changes
  • There are no other concerns
  • I have not discovered any new uncovered test/use cases

@SvetlanaMaliugina SvetlanaMaliugina requested a review from a team as a code owner July 11, 2022 08:22
@SvetlanaMaliugina SvetlanaMaliugina changed the title Fixed vulnerabilities in MSBuildV1 task Fixed vulnerabilities in MSBuildV1 task and updated task-lib-version till 3.3.1 Jul 11, 2022
@SvetlanaMaliugina
Copy link
Contributor Author

Copy link
Contributor

@DenisRumyantsev DenisRumyantsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it end-to-end, MSBuildV1 , VSBuildV1 , and XamarinAndroidV1 tasks work fine with these changes.

@SvetlanaMaliugina SvetlanaMaliugina merged commit 18cecc9 into master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants