Removed SAS token for VHD downloads #2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Egil Ring <janegilring@microsoft.com>
|
Hi janegilring! Thank you for opening this Pull Request. Someone will review it soon. Thank you for committing to making the Azure Arc Jumpstart better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on changes made to the
azure_jumpstart_arcbox/artifacts/ArcServersLogonScript.ps1file. The changes is aimed at simplifying the way Azure'sazcopycommand is used to copy VHD files from a source folder. The changes remove the use of a Shared Access Signature (SAS) token and modify the$vhdSourceFoldervariable to directly include the path to the VHD files.Here are the key changes:
azure_jumpstart_arcbox/artifacts/ArcServersLogonScript.ps1: The$vhdSourceFoldervariable was modified to directly include the path to the VHD files, removing the need for the$sasvariable. This change simplifies the URL used in theazcopycommand.azure_jumpstart_arcbox/artifacts/ArcServersLogonScript.ps1: Theazcopycommand was updated to remove the$sasvariable from the source URL. This change was made in the conditional block for the "DevOps" flavor.azure_jumpstart_arcbox/artifacts/ArcServersLogonScript.ps1: Similar to the previous change, theazcopycommand was updated to remove the$sasvariable from the source URL. This change was made in the conditional block for the "Full" flavor and other flavors.Resolves #2551