Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on simplifying and enhancing the security of the Azure scripts in the
azure_jumpstart_arcbox/artifacts
directory. The changes involve removing the need to pass the tenant ID during Azure CLI login, replacing the use of Azure Service Principal with Managed Identity for Azure account connection, and updating the role definition ID for the Key Vault Certificates Officer in theclientVm.bicep
file.Azure CLI Login:
azure_jumpstart_arcbox/artifacts/ArcServersLogonScript.ps1
: Removed the need to pass the tenant ID during Azure CLI login. This simplifies the login process and enhances security by reducing the need to handle sensitive data.Azure Account Connection:
azure_jumpstart_arcbox/artifacts/ArcServersLogonScript.ps1
: Added variables for tenant ID, subscription ID, and resource group to the script block in theForEach-Object
loop. This allows the script to use these variables when connecting to the Azure account.azure_jumpstart_arcbox/artifacts/Bootstrap.ps1
: Replaced the environment variable$env:resourceGroup
with$resourceGroup
when getting the Key Vault. This ensures the correct resource group is used when connecting to the Azure account.azure_jumpstart_arcbox/artifacts/Bootstrap.ps1
: Replaced the test secrets with actual secrets when setting the secrets in the Key Vault. This enhances security by ensuring that real secrets are stored in the Key Vault.azure_jumpstart_arcbox/artifacts/tests/common.tests.ps1
andazure_jumpstart_arcbox/artifacts/tests/itpro.tests.ps1
: Replaced the use of Azure Service Principal with Managed Identity when connecting to the Azure account. This enhances security by leveraging Azure's identity management capabilities. [1] [2]Role Definition ID Update:
azure_jumpstart_arcbox/bicep/clientVm/clientVm.bicep
: Updated the role definition ID for the Key Vault Certificates Officer. This ensures the correct role is assigned to the principal.