Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArcBox 3.0 optimizations #2569

Merged

Conversation

janegilring
Copy link
Contributor

This pull request primarily focuses on simplifying and enhancing the security of the Azure scripts in the azure_jumpstart_arcbox/artifacts directory. The changes involve removing the need to pass the tenant ID during Azure CLI login, replacing the use of Azure Service Principal with Managed Identity for Azure account connection, and updating the role definition ID for the Key Vault Certificates Officer in the clientVm.bicep file.

Azure CLI Login:

Azure Account Connection:

  • azure_jumpstart_arcbox/artifacts/ArcServersLogonScript.ps1: Added variables for tenant ID, subscription ID, and resource group to the script block in the ForEach-Object loop. This allows the script to use these variables when connecting to the Azure account.
  • azure_jumpstart_arcbox/artifacts/Bootstrap.ps1: Replaced the environment variable $env:resourceGroup with $resourceGroup when getting the Key Vault. This ensures the correct resource group is used when connecting to the Azure account.
  • azure_jumpstart_arcbox/artifacts/Bootstrap.ps1: Replaced the test secrets with actual secrets when setting the secrets in the Key Vault. This enhances security by ensuring that real secrets are stored in the Key Vault.
  • azure_jumpstart_arcbox/artifacts/tests/common.tests.ps1 and azure_jumpstart_arcbox/artifacts/tests/itpro.tests.ps1: Replaced the use of Azure Service Principal with Managed Identity when connecting to the Azure account. This enhances security by leveraging Azure's identity management capabilities. [1] [2]

Role Definition ID Update:

Signed-off-by: Jan Egil Ring <janegilring@microsoft.com>
Signed-off-by: Jan Egil Ring <janegilring@microsoft.com>
Signed-off-by: Jan Egil Ring <janegilring@microsoft.com>
Signed-off-by: Jan Egil Ring <janegilring@microsoft.com>
Signed-off-by: Jan Egil Ring <janegilring@microsoft.com>
@janegilring janegilring added the ArcBox Jumpstart ArcBox related label May 24, 2024
@janegilring janegilring added this to the June 2024 milestone May 24, 2024
@janegilring janegilring self-assigned this May 24, 2024
@janegilring janegilring merged commit d635ef9 into microsoft:arcbox_3.0 May 24, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ArcBox Jumpstart ArcBox related
Projects
Development

Successfully merging this pull request may close these issues.

1 participant