Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the azure auth for postgresql #10662

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Fixes the azure auth for postgresql #10662

merged 1 commit into from
Jun 4, 2020

Conversation

aaomidi
Copy link
Contributor

@aaomidi aaomidi commented Jun 1, 2020

Attempts to fix the postgresql issue with authentication.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 34.813% when pulling a98fd1b on amir/postgres/fixAuth into 534eb3a on master.

@swjain23 swjain23 mentioned this pull request Jun 4, 2020
30 tasks
@Charles-Gagnon
Copy link
Contributor

@aaomidi Anything blocking this going in?

@aaomidi
Copy link
Contributor Author

aaomidi commented Jun 4, 2020

@Charles-Gagnon I haven't confirmed this fixes their problem. I am waiting for a signoff from the postgre team.

@swjain23 swjain23 requested a review from rich617 June 4, 2020 22:39
@aaomidi aaomidi merged commit 70af4cb into master Jun 4, 2020
@aaomidi aaomidi deleted the amir/postgres/fixAuth branch June 4, 2020 23:01
@swjain23
Copy link
Contributor

swjain23 commented Jun 4, 2020

@aaomidi - Richard has verified that the PR solves the issue. Just for future reference, if we find a problem with Release, what is the process? do we comment on the release issue or send an email?

@aaomidi
Copy link
Contributor Author

aaomidi commented Jun 4, 2020

Opening an issue and linking to it in an email is great! I'll make a port request this for release now, please make sure to test the release RCs on #10720

I'll link to the port request PR here as well

aaomidi pushed a commit that referenced this pull request Jun 4, 2020
@aaomidi
Copy link
Contributor Author

aaomidi commented Jun 4, 2020

#10753

@swjain23
Copy link
Contributor

swjain23 commented Jun 4, 2020

Got it, thank you :). We will test it once it is merged to release branch.

@rich617
Copy link
Contributor

rich617 commented Jun 5, 2020

I still think we need a connection property that returns true if authType is either AzureMFA or AzureMFAAndUser because that test is in a lot of places. If no one has time, maybe I'll give it a go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants