Address issues with revert in Edit Data and also add trim to string data from cells. #24906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6788992394
💛 - Coveralls |
|
Issue has been linked |
cheenamalhotra
approved these changes
Nov 8, 2023
| @@ -232,10 +232,12 @@ export class EditDataGridPanel extends GridParentComponent { | |||
| // If a cell is not edited and retrieved direct from the SQL server, it would be in the form of a DBCellValue. | |||
| // We use the DBCellValue's cleaned displayValue as the text value. | |||
| returnVal = this.replaceLinebreaks(value.displayValue); | |||
| returnVal = returnVal.trim(); | |||
There was a problem hiding this comment.
What if the user actually wants to add spaces to the beginning/end of the string? Isn't this going to prevent that from happening?
siyao-Siyang
pushed a commit
that referenced
this pull request
Nov 13, 2023
…ata from cells. (#24906) * small fix to edit data minor issues * Added trim for values retrieved from cell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix an issue with edit data upon revert for an invalid edit causing the current Cell to become reset when it should only be done for manual revert. (This results in additional edits after the revert on the cell not working until you move to a different row or refresh the edit session entirely).
Additionally, this PR addresses a bug where empty spaces at the end are a part of the value retrieved from the cell and that failure to delete those or overwrite them causes a "exceeded length" error, this PR adds trimming to values from the cell (and it still registers as being unchanged by the editor).