Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sql.tmLanguage.json after added color keywords done in VsCode. #25122

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

jingzhao65
Copy link
Contributor

This is part of the fix for bug: https://msdata.visualstudio.com/Database%20Systems/_workitems/edit/935561.
Added the keywords from graphDB query, MATCH, CONNECTION, SHORTES_PATH, to coloring keywords in SqlParser, then updated VsCode related to the changes, and this is the last step to update sql.tmLanguage.json in ADS.

@Charles-Gagnon
Copy link
Contributor

I'll handle merging in once the checks pass, thanks @jingzhao65 !

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7187939402

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 41.604%

Totals Coverage Status
Change from base Build 7175736451: 0.006%
Covered Lines: 30818
Relevant Lines: 69389

💛 - Coveralls

@jingzhao65
Copy link
Contributor Author

Thanks Charles!

@Charles-Gagnon Charles-Gagnon merged commit 896aa3a into main Dec 12, 2023
13 checks passed
@Charles-Gagnon Charles-Gagnon deleted the dev/zhajin/addcolor_keywords branch December 12, 2023 23:41
@Charles-Gagnon
Copy link
Contributor

@jingzhao65 You can check out the insiders build tomorrow to verify everything looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants