Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Login Migration Validation API RPC support #25198

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Added Login Migration Validation API RPC support #25198

merged 1 commit into from
Jan 12, 2024

Conversation

Bhavikshah123
Copy link
Contributor

  • Updated the new version of SQL tools service from 4.11.0.13 to 4.11.0.17 that created 4 RPC corresponding to the below validation api's
  1. ValidateSysAdminPermissions
  2. ValidateAADDomainName
  3. ValidateLoginEligibility
  4. ValidateAADDomainName
  • Created the RPC requests for the validation API's
  1. ValidateSysAdminPermissionRequest
  2. ValidateUserMappingRequest
  3. ValidateAADDomainNameRequest
  4. ValidateLoginEligibilityRequest
  • Testing
    Tested all the RPC calls to the validation API's by consuming the sqltoolsservice in the ADS client locally.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7487746158

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 41.761%
Totals Coverage Status
Change from base Build 7482522687: -0.001%
Covered Lines: 30826
Relevant Lines: 69073
💛 - Coveralls

stuti149
stuti149 reviewed Jan 12, 2024
View reviewed changes
extensions/sql-migration/src/service/features.ts

}
catch (e) {
this._client.logFailedRequest(contracts.ValidateSysAdminPermissionRequest.type, e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where we are logging these failed requests?

@Bhavikshah123 Bhavikshah123 merged commit 1f88189 into main Jan 12, 2024
15 checks passed
@Bhavikshah123 Bhavikshah123 deleted the user/bhavikshah/LoginMigrationValidation branch January 12, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuti149 stuti149 stuti149 approved these changes

@AkshayMata AkshayMata Awaiting requested review from AkshayMata

@raymondtruong raymondtruong Awaiting requested review from raymondtruong raymondtruong is a code owner

@brian-harris brian-harris Awaiting requested review from brian-harris

@junierch junierch Awaiting requested review from junierch

@RamyaR29 RamyaR29 Awaiting requested review from RamyaR29

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bhavikshah123 @coveralls @stuti149