Add restore from S3 url #25216
Add restore from S3 url #25216
Conversation
barbaravaldez
commented
Jan 16, 2024
•
barbaravaldez
commented
barbaravaldez
requested review from
alanrenmsft and
Charles-Gagnon
as code owners
Pull Request Test Coverage Report for Build 7789684642Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
| /** | ||
| * Create a new credential | ||
| * @param connectionUri The URI of the server connection. | ||
| * @param credentialInfo |
| const credentialInfo: azdata.CredentialInfo = { | ||
| secret: `${result.accessKey}:${result.secretKey}`, | ||
| url: result.s3Url.toString(), | ||
| identity: 'S3 Access Key', |
There was a problem hiding this comment.
Would suggest linking to the docs about this hardcoded value
extensions/mssql/src/objectManagement/ui/restoreDatabaseDialog.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Cory Rivera <corivera@microsoft.com>
|
On average, how long does it take to do the restore operation? Seems like the dialog is spinning for a while before succeeding. Before I noticed the spinner it almost seemed like the dialog wasn't doing anything at all. |
Adding the credential is very fast, what takes longer is to retrieve the restore information. I think this happens for the URL from blob restore as well. |
| id: undefined | ||
| } | ||
| await this.objectManagementService.createCredential(this.connectionUri, this.credentialInfo); | ||
| this.result.backupFilePath = `s3://${this.bucketDropdown.value}.s3.${this.regionInputBox.value}.amazonaws.com/${this.backupFilesDropdown.value}`; |
There was a problem hiding this comment.
Do any of these values need to be escaped?
