Add Ledger option to Create Database dialog #25224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7589005693
💛 - Coveralls |
kisantia
approved these changes
Jan 19, 2024
| @@ -378,6 +378,13 @@ export class DatabaseDialog extends ObjectManagementDialogBase<Database, Databas | |||
| containers.push(this.createLabelInputContainer(localizedConstants.ContainmentTypeText, containmentDropbox)); | |||
| } | |||
|
|
|||
| if (!isUndefinedOrNull(this.objectInfo.isLedgerDatabase)) { | |||
| let isLedgerDatabaseInput = this.createCheckbox(localizedConstants.IsLedgerDatabaseText, async () => { | |||
There was a problem hiding this comment.
Remove this async? I don't see any awaits in the block
There was a problem hiding this comment.
The callback argument to createCheckbox (and many others) always expects a Promise return type
barbaravaldez
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24544
List of changes in the STS version bump:
