Single click SHIR #25350
Single click SHIR #25350
Conversation
Pull Request Test Coverage Report for Build 8075278873Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
RamyaR29
requested review from
AkshayMata,
raymondtruong,
brian-harris and
junierch
as code owners
| const data: DeclarativeTableCellValue[][] = [ | ||
| [ | ||
| { value: " " }, | ||
| { value: "No node found" }, |
There was a problem hiding this comment.
same here, should be added as resource string in strings.ts
| @@ -33,7 +33,7 @@ $timeStamp = [System.DateTime]::Now.ToString("yyyyMMddHHmmss") | |||
| $Global:ScriptId = "Script-$timestamp" | |||
|
|
|||
| # TODO: Auto populate | |||
| $Global:LatestIRVersion = [Version]"5.35.8686.1" | |||
| $Global:LatestIRVersion = [Version]"5.34.8675.1" | |||
There was a problem hiding this comment.
recommend updating this version to 5.37.. as well
There was a problem hiding this comment.
5.34 is the recommended version based on this link https://go.microsoft.com/fwlink/?linkid=839822
| await fs.writeFile(choosenPath.fsPath, value); | ||
| if (await vscode.window.showInformationMessage( | ||
| "PowerShell script saved", | ||
| "Open", "Cancel") === "Open") { |
There was a problem hiding this comment.
need to create resource strings for these as well for localization.
|
I'm not able to access the links above, can you please add images to the descrition |
|
@RamyaR29 can you add the Screen shots of UI that is build (also check in dark mode if everything looks good) |
| const manualIRconfigurationExpander = view.modelBuilder.button().withProps( | ||
| { | ||
| iconPath: IconPathHelper.expandButtonClosed, | ||
| ariaLabel: 'Manual IR configuration collapsed' |
There was a problem hiding this comment.
these labels should be replaced with resource strings
| // opens IR dialog | ||
| public async openIRDialog(): Promise<void> { | ||
| const configureIR = new ConfigureIRDialog(this.migrationStateModel); | ||
| await configureIR.openDialog(); |
There was a problem hiding this comment.
You may add a try catch here to handle and log error if IR dialog opening fails due to any error.
This PR implements the single click SHIR feature,
more information on the feature -
Figma - End to End Design GA - SQL Migration ADS – Figma
IR table
Configure IR
New DMS page
