Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inline commands for dropping objects #25399

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

corivera
Copy link
Member

For #25366

We already have Drop commands in the context menu, so the inline commands are unnecessary and can be clicked accidentally.

@Charles-Gagnon
Copy link
Contributor

I would suggest just removing the drop DB but leaving the rest - it's much more common that someone will be dropping an object and having to open up the context menu and find the entry can be annoying.

@corivera
Copy link
Member Author

@Charles-Gagnon We opted to remove all of them to handle the whole class of potential "I accidentally dropped X" issues

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8023858738

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.008%) to 41.755%

Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/dialog/configurePython/configurePythonWizard.ts 1 46.46%
src/sql/workbench/services/connection/browser/connectionDialogWidget.ts 1 73.44%
extensions/notebook/src/common/ports.ts 4 74.14%
Totals Coverage Status
Change from base Build 8023197128: -0.008%
Covered Lines: 30825
Relevant Lines: 69082

💛 - Coveralls

@kisantia
Copy link
Contributor

@Charles-Gagnon We opted to remove all of them to handle the whole class of potential "I accidentally dropped X" issues

Yup, also ran this by @erinstellato-ms and she's good with removing all the drop icons and having them only available via right-click

@corivera
Copy link
Member Author

Build failure looks to be network related. I'll go ahead and merge this

@corivera corivera merged commit 9c4f37f into main Feb 23, 2024
13 of 15 checks passed
@corivera corivera deleted the corivera/removeInlineDrop branch February 23, 2024 20:03
kisantia added a commit that referenced this pull request Feb 24, 2024
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants