"File not found" error fixed for SQL inline migration #25453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
February 21, 2024 00:44
RamyaR29
requested review from
AkshayMata,
raymondtruong,
brian-harris and
junierch
as code owners
Pull Request Test Coverage Report for Build 8106254216Details
💛 - Coveralls |
Ramudaykumar
reviewed
Mar 1, 2024
| @@ -875,7 +875,7 @@ export async function createManualIRconfigContentContainer(view: azdata.ModelVie | |||
| if (service) { | |||
| const account = migrationStateModel._azureAccount; | |||
| const subscription = migrationStateModel._sqlMigrationServiceSubscription; | |||
| const resourceGroup = migrationStateModel._sqlMigrationServiceResourceGroup.name; | |||
| const resourceGroup = service.properties.resourceGroup; | |||
| const location = service.location; | |||
| const serviceName = service.name; | |||
There was a problem hiding this comment.
Service name also should be newer one, right? but if it is working fine locally that we can go ahead.
There was a problem hiding this comment.
service name is the name property of the service and this service is assigned in the previous stage with the newly created service.
Ramudaykumar
approved these changes
Mar 1, 2024
Ramudaykumar
approved these changes
Mar 1, 2024
Ramudaykumar
reviewed
Mar 1, 2024
|
|
||
| // inject auth keys in the script | ||
| const authKeys = await retrieveAuthKeys(migrationStateModel); | ||
| const modifiedScriptContent = await injectKeysIntoShirScriptContent | ||
| (authKeys.authKey1, authKeys.authKey2, scriptContent.toString()); | ||
|
|
||
| // write it back to different file | ||
| const modifiedScriptPath = path.join(__dirname, '../../scripts/SHIR-auto-configuration-with-auth-keys.ps1'); | ||
| const modifiedScriptPath = path.join(__dirname, '../scripts/SHIR-auto-configuration-with-auth-keys.ps1'); |
There was a problem hiding this comment.
That is why we should add these string constants, otherwise we need to update at everyplace. And there is risk of missing some of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"File not found" error fixed for SQL inline migration
The __dirname name here calls for the working directory which is sql extension folder and from there we are navigating to scripts folder to get the required script