Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attaching Preview option with Next gen GP enabled #25555

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Attaching Preview option with Next gen GP enabled #25555

merged 1 commit into from
Apr 3, 2024

Conversation

stuti149
Copy link
Contributor

@stuti149 stuti149 commented Apr 2, 2024 •
edited
Loading

This PR makes NextGen GP recommendations to be produced based on toggle preview button.

image

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8518448567

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 41.759%
Totals Coverage Status
Change from base Build 8511640437: 0.002%
Covered Lines: 30828
Relevant Lines: 69082
💛 - Coveralls

Ramudaykumar
Ramudaykumar reviewed Apr 2, 2024
View reviewed changes
Copy link
Contributor

@Ramudaykumar Ramudaykumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Hope you have tested it thoroughly. I have made a recent in SQL NuGet for Next Gen GP in SKU recommendation report, but that should not impact this.

@stuti149 stuti149 merged commit cbdeeb2 into main Apr 3, 2024
12 checks passed
@stuti149 stuti149 deleted the stutijain/add-preview-option branch April 3, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ramudaykumar Ramudaykumar Ramudaykumar approved these changes

@AkshayMata AkshayMata Awaiting requested review from AkshayMata

@raymondtruong raymondtruong Awaiting requested review from raymondtruong raymondtruong is a code owner

@brian-harris brian-harris Awaiting requested review from brian-harris

@junierch junierch Awaiting requested review from junierch

@krritik krritik Awaiting requested review from krritik

@sahuroshan sahuroshan Awaiting requested review from sahuroshan

@cpichuka cpichuka Awaiting requested review from cpichuka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stuti149 @coveralls @Ramudaykumar