Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] golang: switch to microsoft/go & bump version to 1.18.0 #2545

Closed
wants to merge 9 commits into from

Conversation

mfrw
Copy link
Member

@mfrw mfrw commented Mar 18, 2022

Signed-off-by: Muhammad Falak R Wani falakreyaz@gmail.com

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

TODO
Summary

What does the PR accomplish, why was it needed?
Switch to micrsoft/go which supports a fips compliant release.

Change Log
  • Switch to micrsoft/go instead of golang/go
Does this affect the toolchain?

NA

Associated issues
Links to CVEs
  • NA
Test Methodology
  • Pipeline build id: Local Build with RUN_CHECK=y

@ghost ghost added the main PR Destined for main label Mar 18, 2022
@mfrw mfrw changed the title golang: switch to microsoft/go & bump version to 1.18.0 [RFC] golang: switch to microsoft/go & bump version to 1.18.0 Mar 18, 2022
@mfrw mfrw force-pushed the mfrw/bump-go-1.18-ohh-yeah-generics branch from 0144cc2 to e317703 Compare March 25, 2022 05:12
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
…liance

Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
…ble fips compliance

Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
@mfrw mfrw force-pushed the mfrw/bump-go-1.18-ohh-yeah-generics branch from e317703 to b1e2dae Compare March 27, 2022 07:40
@mfrw mfrw closed this Oct 3, 2023
@mfrw mfrw deleted the mfrw/bump-go-1.18-ohh-yeah-generics branch October 3, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant