Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure gpg commands inside mariner-repos.spec are run during image creation #42

Merged
merged 7 commits into from
Aug 19, 2020

Conversation

mrgirgin
Copy link
Contributor

Summary

Ensure the gpg commands in the %post section of mariner-repos.spec will be run during image creation.

Change Log
  • Added 'gpg' and its dependencies inside the chroot
  • Added tdnf-plugin-repogpgcheck to chroot to enable metadata gpgcheck inside the chroot.
  • Added pinentry to the toolchain, as it is a runtime dependency by gpg.
  • Fixed a bug in safechroot that sets the home directory for root user to /home/root instead of /root.
  • Added stopGPGAgent to be run at chroot termination as gpg-agent was holding locks inside the chroot and preventing the unmount operations.
Does this affect the toolchain?

YES

Merge Checklist
  • The toolchain has been rebuilt successfully if any changes were made to it
  • The toolchain/worker package manifests have been updated if this is a toolchain package
  • Updated packages have been successfully built
  • New source files have updated hashes in the *.signatures.json files
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Copy link
Contributor

@christopherco christopherco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@jslobodzian jslobodzian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jslobodzian jslobodzian merged commit a6ce30a into main Aug 19, 2020
@mrgirgin mrgirgin deleted the mrgirgin/add-tdnf-repogpgcheck-to-chroot branch August 20, 2020 18:22
henryli001 pushed a commit that referenced this pull request Jun 15, 2021
…to-chroot

Ensure gpg commands inside mariner-repos.spec are run during image creation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants