Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sofus: added example for runtime schema validation #974

Closed

Conversation

sofusmortensen
Copy link

No description provided.

@msftclas
Copy link

msftclas commented May 15, 2019

CLA assistant check
All CLA requirements met.

@lalo
Copy link
Member

lalo commented May 17, 2019

Does this merit a change on the changelog file?

@sofusmortensen
Copy link
Author

@lalo Thanks - yeah, you're right. I believe any change to the source code, especially when changing the API, merits a note in the changelog.

@sofusmortensen
Copy link
Author

@sapek I would appreciate some feedback on this?

@sapek
Copy link
Contributor

sapek commented Jun 3, 2019

I apologize for the delay. I didn't forget about it but I've been insanely busy in the last several weeks. I will get back to the PR as soon as can. I'll try sooner but realistically it might be the second half of June.

@sofusmortensen
Copy link
Author

@sapek np! thanks

@chwarr
Copy link
Member

chwarr commented Nov 7, 2019

Are either of you, @sofusmortensen or @sapek, still working on this PR? If not, should we close it?

@sofusmortensen
Copy link
Author

Still waiting for review.

@sofusmortensen
Copy link
Author

@sapek - please take a look.

@sapek
Copy link
Contributor

sapek commented Feb 5, 2020

I really apologize but I haven't been able to carve out time to look at this.

@sofusmortensen
Copy link
Author

@sapek anybody else who can help move this forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants