Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External Entities & Dynamic lists #3300

Merged
merged 32 commits into from
Jan 29, 2020
Merged

External Entities & Dynamic lists #3300

merged 32 commits into from
Jan 29, 2020

Conversation

chrimc62
Copy link
Contributor

Fix for #3156 which now enables external entity recognizers and dynamic lists for declarative LUIS recognizers.
*** Breaking change for declarative LUIS Recognizers ***
They now use expressions so to bind you need to do "=luis.settings.endpointKey" rather than "{luis.settings.endpointKey}". There is also a PR to update bf-cli.

Dropped $role of lg and memorypath since not used.
Changed it so $role of expression would add string type.
Updated TestBot to include settings.
Moved all of the PropertyExpression stuff to its own library. Once it no longer depends on .lg we can move it into the actual expression library.

@chrimc62
Updated schema.
1835bdd
@chrimc62
Added DynamicList and External entity support to declarative LUIS Rec…
3c1eb17 
…ognizer.

Improved MockLuis to pay attention to parameters.
@chrimc62
Merge with master.
32ad149
@chrimc62
Update cache files.
e649f6c
@chrimc62
Update LuisRecognizerOptionsV3 to include support for DialogContext.
a332bd6
@chrimc62
ExternalEntity recognizer tests running.
7f771a9
@chrimc62
Merge with master.
59116f0
@chrimc62
Merge branch 'master' into chrimc/luis
fa9b7b4
@chrimc62
Move LUIS loader and convert to LUIS library.
cbfeda3
@chrimc62
Update TestBot to better handle one dialog.
1fcc9c9
@chrimc62
Fix TestBot to work more reliably.
6518aa4
@chrimc62
Merge branch 'master' into chrimc/luis
79ba6d1
@chrimc62
Merge with master.
4120e28
@chrimc62
Move expression properties to its own library in order to support usi…
a05a3a3 
…ng them in LUIS Recognizer without introducing cycles.
@chrimc62
Fix bogus build warnings.
f2ccd92
@chrimc62
Connect expresssion to dynamic lists.
401edb1
@chrimc62
Merge branches.
39fee48
@chrimc62
Add LuisAdaptiveRecognizer to wrap LUISRecognizer functionality inclu…
92d2685 
…ding expressions. This is also a breaking change because appid, etc. now is expressions.

Fixed bug in ArrayExpressionConverter where other convertes would not be used.
@chrimc62
Add explicit adapter dynamic list to get around serialization/deseria…
692434c 
…lization issues.

Add test that uses expression.
@chrimc62
Merge with latest.
8eb660b
@chrimc62
Update generator unit tests.
d16061a
@chrimc62
Switch to $role filling in string type.
f66087e 
Get rid of lg and memorypath roles.
@chrimc62
Merge branch 'master' into chrimc/luis
fa85856
@coveralls
Copy link
Collaborator

coveralls commented Jan 28, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 102465

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 78 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.08%) to 79.544%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs.Declarative/ComponentRegistration.cs 1 75.0%
/libraries/Microsoft.Bot.Builder.Dialogs.Declarative/DeclarativeTypeLoader.cs 6 73.21%
/libraries/Microsoft.Bot.Builder.AI.LUIS/LuisRecognizerOptionsV2.cs 8 82.14%
/libraries/Microsoft.Bot.Builder.AI.LUIS/LuisRecognizerOptionsV3.cs 28 73.87%
/libraries/Microsoft.Bot.Builder.AI.LUIS/LuisRecognizer.cs 35 72.22%
Totals Coverage Status
Change from base Build 102418: -0.08%
Covered Lines: 10841
Relevant Lines: 13629
💛 - Coveralls

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

tomlm
tomlm reviewed Jan 29, 2020
View reviewed changes
Microsoft.Bot.Builder.sln Outdated Show resolved Hide resolved
tomlm
tomlm approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tomlm tomlm added adaptive R8 Release 8 - March 16th, 2020 labels Jan 29, 2020
@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

@chrimc62 chrimc62 merged commit a9ccf38 into master Jan 29, 2020
@chrimc62 chrimc62 deleted the chrimc/luis branch January 29, 2020 22:33
This was referenced Jan 29, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlm tomlm tomlm approved these changes

@munozemilio munozemilio Awaiting requested review from munozemilio

Assignees
No one assigned
Labels
R8 Release 8 - March 16th, 2020
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrimc62 @coveralls @fuselabs @tomlm