Add ShowSignInLink to OAuthPromptSettings #5906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabog
reviewed
Oct 7, 2021
gabog
approved these changes
Oct 7, 2021
EricDahlvang
approved these changes
Oct 7, 2021
gabog
reviewed
Oct 7, 2021
This was referenced Oct 7, 2021
mrivera-ms
added a commit
that referenced
this pull request
Nov 9, 2021
* Add ShowSignInLink to OAuthPromptSettings * Refactor tests
mrivera-ms
added a commit
that referenced
this pull request
Nov 9, 2021
* Add ShowSignInLink to OAuthPromptSettings * Refactor tests
mrivera-ms
added a commit
that referenced
this pull request
Nov 9, 2021
mrivera-ms
added a commit
that referenced
this pull request
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5887
Description
The decision of showing a SignIn link depends on the channel Id in use. This change adds an optional value to OAuthPromptSettings to override the default implementation in
botbuilder-dotnet/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/OAuthPrompt.cs
Line 602 in e176bb5
Testing
A data driven test is being added that verify the link value is calculated correctly: