Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: Add ShowSignInLink to OAuthPromptSettings (#5906) #1814

Closed
github-actions bot opened this issue Oct 7, 2021 · 0 comments
Closed

port: Add ShowSignInLink to OAuthPromptSettings (#5906) #1814

github-actions bot opened this issue Oct 7, 2021 · 0 comments
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.

Comments

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

The changes in Add ShowSignInLink to OAuthPromptSettings (#5906) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #5887

Description

The decision of showing a SignIn link depends on the channel Id in use. This change adds an optional value to OAuthPromptSettings to override the default implementation in
https://github.com/microsoft/botbuilder-dotnet/blob/e176bb576105538cd179187f4c19b2818d2578e7/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/OAuthPrompt.cs#L602

Testing

A data driven test is being added that verify the link value is calculated correctly:

image

Please review and, if necessary, port the changes.
@github-actions github-actions bot added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tracyboehrer