Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cherry-pick to 4.14] Add ShowSignInLink to OAuthPromptSettings (#5906) #5967

Merged
merged 1 commit into from
Nov 9, 2021
Merged

[Cherry-pick to 4.14] Add ShowSignInLink to OAuthPromptSettings (#5906) #5967

merged 1 commit into from
Nov 9, 2021

Conversation

mrivera-ms
Copy link
Contributor

  • Add ShowSignInLink to OAuthPromptSettings

  • Refactor tests

Fixes #5887

@mrivera-ms
Add ShowSignInLink to OAuthPromptSettings (#5906)
e78cbcd 
* Add ShowSignInLink to OAuthPromptSettings

* Refactor tests
@mrivera-ms mrivera-ms requested a review from a team as a code owner November 9, 2021 23:00
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 276914

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 16 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.008%) to 75.787%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/OAuthPrompt.cs 16 88.98%
Totals Coverage Status
Change from base Build 276429: 0.008%
Covered Lines: 22981
Relevant Lines: 30323
💛 - Coveralls

@mrivera-ms mrivera-ms merged commit 0a691c5 into 4.14 Nov 9, 2021
@mrivera-ms mrivera-ms deleted the moniriv/cherryp5906_2 branch November 9, 2021 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricDahlvang EricDahlvang EricDahlvang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrivera-ms @coveralls @EricDahlvang