Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IStreamingTransportClient to exports #1270

Merged
merged 4 commits into from
Oct 10, 2019
Merged

Add IStreamingTransportClient to exports #1270

merged 4 commits into from
Oct 10, 2019

Conversation

DDEfromOR
Copy link
Member

Fixes #1222

Description

This change adds two interfaces to the list of exports from the package root, for parity with the C# library's surface area.

Specific Changes

  • Added IReceiveResponse to the export list
  • Added IStreamingTransportClient to the export list

@coveralls
Copy link

coveralls commented Oct 7, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 82666

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.808%
Totals Coverage Status
Change from base Build 82662: 0.0%
Covered Lines: 4669
Relevant Lines: 5172
💛 - Coveralls

@DDEfromOR DDEfromOR merged commit ec26392 into master Oct 10, 2019
@DDEfromOR DDEfromOR deleted the dev/se-export-transportclient branch October 10, 2019 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosscastro carlosscastro carlosscastro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BotFramework-Streaming-Extensions] Missing to export interfaces
4 participants
@DDEfromOR @coveralls @carlosscastro @stevengum