Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QnA Maker] opim auth header for V5 support #2001

Merged
merged 6 commits into from
Apr 9, 2020
Merged

[QnA Maker] opim auth header for V5 support #2001

merged 6 commits into from
Apr 9, 2020

Conversation

vipeketi
Copy link
Contributor

@vipeketi vipeketi commented Apr 8, 2020

Fixes #

Description

opim auth header is added for v5 support

Specific Changes

Similar changes to dotnet sdk PR 3690

Testing

@coveralls
Copy link

coveralls commented Apr 8, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 118809

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.09%) to 66.942%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 118761: -0.09%
Covered Lines: 10236
Relevant Lines: 14466
💛 - Coveralls

@vipeketi vipeketi mentioned this pull request Apr 9, 2020
Merged
@vishwacsena vishwacsena merged commit 4dd290c into master Apr 9, 2020
@vishwacsena vishwacsena deleted the vipeketi/opimauthheader branch April 9, 2020 18:12
@stevengum stevengum mentioned this pull request Apr 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@somigithub somigithub somigithub approved these changes

@vishwacsena vishwacsena vishwacsena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vipeketi @coveralls @somigithub @vishwacsena