Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test case for CancelAllDialogs #2049

Merged
merged 3 commits into from
Apr 22, 2020
Merged

Added test case for CancelAllDialogs #2049

merged 3 commits into from
Apr 22, 2020

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Apr 16, 2020

Fixes #1892

Description

Added test case for CancelAllDialogs and fixed possible undefined eventName/eventValue.

Specific Changes

  • Fixed possible undefined eventName/eventValue in CancelAllDialogs

Testing

Added test case for CancelAllDialogs

@chon219 chon219 requested a review from Stevenic April 16, 2020 08:12
@chon219 chon219 self-assigned this Apr 16, 2020
@coveralls
Copy link

coveralls commented Apr 16, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 122842

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 77.503%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs-adaptive/src/actions/cancelAllDialogs.ts 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 122833: -0.02%
Covered Lines: 11889
Relevant Lines: 14618
💛 - Coveralls

stevengum
stevengum approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified through diffchecker that the .dialog file here is the same as the one in the dotnet PR.

@chon219 chon219 merged commit d32dd1d into master Apr 22, 2020
@chon219 chon219 deleted the zim/cancelalldialogs-fix branch April 22, 2020 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

Assignees

@chon219 chon219

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PORT] Add unit test for CancelAllDialogs and fix eventName and eventValue null
3 participants
@chon219 @coveralls @stevengum