Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable overriding AttachmentInput #3122

Merged
merged 2 commits into from
Dec 4, 2020
Merged

fix: enable overriding AttachmentInput #3122

merged 2 commits into from
Dec 4, 2020

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Dec 4, 2020

Fixes #3032

Description

This fixes a bug where a custom dialog inheriting from AttachmentInput will currently fail.

Specific Changes

  • use instanceOf instead of comparing class names in InputDialog

Testing

Ported tests from C#.

@chon219 chon219 added the Area: Adaptive The issue is related to Adaptive dialogs label Dec 4, 2020
@chon219 chon219 added this to the R12 milestone Dec 4, 2020
@chon219 chon219 requested a review from a team as a code owner December 4, 2020 07:24
@chon219 chon219 requested a review from tomlm December 4, 2020 07:25
@coveralls
Copy link

Pull Request Test Coverage Report for Build 400159264

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 28 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.05%) to 84.75%
Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 4 60.76%
libraries/adaptive-expressions/src/triggerTrees/node.ts 8 91.7%
libraries/botbuilder-dialogs-adaptive/src/input/inputDialog.ts 16 83.21%
Totals Coverage Status
Change from base Build 399650268: -0.05%
Covered Lines: 17344
Relevant Lines: 19538
💛 - Coveralls

@joshgummersall joshgummersall merged commit 8057f9a into main Dec 4, 2020
@joshgummersall joshgummersall deleted the zim/attachment-input branch December 4, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
Area: Adaptive The issue is related to Adaptive dialogs
Projects
None yet
Milestone
R12
Development

Successfully merging this pull request may close these issues.

[PORT] Enable overriding AttachmentInput dialog
3 participants
@chon219 @coveralls @joshgummersall